From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 5CB0A1FF13A
	for <inbox@lore.proxmox.com>; Wed, 22 Jul 2026 16:10:29 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id B4507214CE;
	Wed, 22 Jul 2026 16:10:28 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 22 Jul 2026 16:10:24 +0200
Message-Id: <DK55S2XVSBGA.30HO2UIRGSY8B@proxmox.com>
To: "Thomas Ellmenreich" <t.ellmenreich@proxmox.com>,
 <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute
 paths as volume ids
From: "Elias Huhsovitz" <e.huhsovitz@proxmox.com>
X-Mailer: aerc 0.20.0
References: <20260722095251.89606-1-t.ellmenreich@proxmox.com>
 <20260722095251.89606-3-t.ellmenreich@proxmox.com>
In-Reply-To: <20260722095251.89606-3-t.ellmenreich@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1784729396759
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.176 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: QKXSDV6AIPROTMWWQ4S5KNLSVSCUGOYF
X-Message-ID-Hash: QKXSDV6AIPROTMWWQ4S5KNLSVSCUGOYF
X-MailFrom: e.huhsovitz@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Small typo, otherwise see review by fiona Ebner [1].

[1:] https://lore.proxmox.com/all/8abb29af-e16d-456b-ab14-cd423abdd801@prox=
mox.com/

On Wed Jul 22, 2026 at 11:52 AM CEST, Thomas Ellmenreich wrote:
> Just like in the case of cdroms, absolute paths to storage drives can be
> skipped when beeing marked as unused as they cannot be owned by the vm.
		^^^
		small typo
>
> Fixes: 5b5c5768 ("display warnings for storage errors or if storage no lo=
nger exists")
> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index ce832c8e..ce0eda74 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -1575,7 +1575,7 @@ sub vmconfig_register_unused_drive {
>          eval { PVE::Storage::vdisk_free($storecfg, $drive->{file}) };
>          warn $@ if $@;
>          delete $conf->{'special-sections'}->{cloudinit};
> -    } elsif (!drive_is_cdrom($drive)) {
> +    } elsif (!drive_is_cdrom($drive) && !drive_is_absolute_path($drive))=
 {
>          my $volid =3D $drive->{file};
>          my ($storeid, undef) =3D PVE::Storage::parse_volume_id($volid);
>          if (PVE::Storage::storage_config($storecfg, $storeid, 1)) {