From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 92AA81FF13A for ; Wed, 22 Jul 2026 14:44:24 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 483E3214D4; Wed, 22 Jul 2026 14:44:24 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 22 Jul 2026 14:43:51 +0200 Message-Id: Subject: Re: [PATCH manager v2 1/2] fix #5475: configurable window title From: "Thomas Ellmenreich" To: "Elias Huhsovitz" , X-Mailer: aerc 0.20.0 References: <20260720100329.118508-1-t.ellmenreich@proxmox.com> <20260720100329.118508-2-t.ellmenreich@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784724203794 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SVC2S6JSKULABKQABWINXH7ZEVJJZGTK X-Message-ID-Hash: SVC2S6JSKULABKQABWINXH7ZEVJJZGTK X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks again for your review. I realised I had a question here as well. [snip] > 1. The setting names render including the $ symbol, e.g. ($nodename, $fqd= n) in the WebUI.=20 > This makes it seem broken from an end user point of view.=20 > You generally do not expect placeholder values in settings menu. Rendering the '$' was on purpose, as they are placeholders. Would you recommend removing just the '$' or would you rather render the actual values? I technically copied it from somewhere, as I had a different placeholder marker, although I can't seem to find that reference anymore. > 2. I encountered a bug regarding the fdqn setting (see comment below) I'm investigating that, especially why I didn't have problems with it. Thanks for noticing. > 3. I recommend adding some general robustness in case of undef values: > Initialize $window_title to a safe value not relying on the cluster, in > case of an error. Expect that the underlying API/calls might return > undef. It was an active choice to show something broken in the case of undef, as I thought hiding the error could also be confusing. But then again, I don't m= ind using the fallback value.