Re: [PATCH manager v9 4/5] fix #7339: lvm: add discard-on-remove option to UI

["Michael Köppl" <m.koeppl@proxmox.com>]

On Mon Jul 13, 2026 at 6:00 PM CEST, Lukas Sichert wrote:

[snip]

> +        let onRemoveString = PVE.Parser.printPropertyString(onRemove);
> +        if (onRemoveString !== '') {
> +            values['on-volume-remove'] = onRemoveString;
> +        } else if (!me.isCreate) {
> +            if (!values.delete) {
> +                values.delete = [];
> +            }
> +            values.delete.push('on-volume-remove');

`values.delete` is not guaranteed to be an array. In other places in
pve-manager, we have explicit checks such as this one:

```
if (Array.isArray(values.delete)) {
    values.delete.push(key);
} else {
    values.delete = [values.delete, key];
}
```

A consequence of this is that if you edit an existing LVM storage with
snapshot-as-volume-chain and discard-on-remove unchecked, you cannot
edit the storage, even if you changed another value. The "OK" button
will simply not do anything. From just a quick glance at the code I
think this is because in the StorageBase component's initComponent,
there is a `deleteEmpty: !me.isCreate` for the snapshot-as-volume-chain
checkbox added for LVM storages, which then results in values.delete
being a string (?) instead of an array (it only becomes an array if more
than 1 value is deleted).

Adding a check like above should solve this.

> +        }
> +
> +        return me.callParent([values]);
> +    },
> +

[snip]