From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CC58B1FF0F1 for ; Mon, 13 Jul 2026 10:11:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 80CFB2134B; Mon, 13 Jul 2026 10:11:57 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 13 Jul 2026 10:11:53 +0200 Message-Id: From: "Lukas Wagner" To: "Dominik Csapak" , "Lukas Wagner" , Subject: Re: [PATCH datacenter-manager 14/15] task cache: trigger repair of corruption after read-accesses X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260702092258.174740-1-l.wagner@proxmox.com> <20260702092258.174740-15-l.wagner@proxmox.com> <669b82d3-1c05-49a6-9594-dd8158526550@proxmox.com> In-Reply-To: <669b82d3-1c05-49a6-9594-dd8158526550@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783930298904 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.338 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XGAHBGBTVL7MNYIBAYJ2RZQR6SUPUCKM X-Message-ID-Hash: XGAHBGBTVL7MNYIBAYJ2RZQR6SUPUCKM X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Jul 10, 2026 at 1:36 PM CEST, Dominik Csapak wrote: >> +/// Shared collection of archive files found to be corrupted while iter= ating. >> +/// >> +/// This is populated during read access (see [`InnerTaskArchiveIterato= r`]) and shared with the >> +/// [`ReadableTaskCache`], which triggers a repair for the collected fi= les when it is dropped. > > > what is meant here with 'whe it's dropped' ? the only drop handler i can > see is for ArchiveFileWriter, but this isn't involved here? > Sorry, left-over of a prototype implementation that instantiated the recovery on drop, I will fix up this comment.