Re: [PATCH storage v8 2/5] lvm: saferemove: zero out volumes range by range

["Michael Köppl" <m.koeppl@proxmox.com>]

On Tue Jul 7, 2026 at 4:32 PM CEST, Lukas Sichert wrote:

[snip]

>  
> -            my $cmd = [
> -                '/usr/bin/cstream',
> -                '-i',
> -                '/dev/zero',
> -                '-o',
> -                $lvmpath,
> -                '-T',
> -                '10',
> -                '-v',
> -                '1',
> -                '-b',
> -                '1048576',
> -                '-t',
> -                "$throughput",

Since this is not used anymore, the schema description for
saferemove_throughput should probably be adapted as well, since it says
"Wipe throughput (cstream -t parameter value)". You adapted the
documentation accordingly, but the schema is still the same. I
unfortunately also missed this in the previous versions.

> -            ];
> -            run_command(
> -                $cmd,
> -                errmsg => "zero out finished (note: 'No space left on device' is ok here)",
> -            );
> -        } else {
> -            # If the storage supports write_zeroes but stepsize is too big, reduce the stepsize to
> -            # the maximum supported by the storage.
> -            if ($write_zeroes_max_bytes > 0 && $stepsize > $write_zeroes_max_bytes) {
> -                print "reduce stepsize to the maximum supported by the storage:"
> -                    . " $write_zeroes_max_bytes bytes\n";
> +        # eval block, so filehandle is closed even if something fails below
> +        eval {
> +            my $start = time();
> +            my $written_total = 0;
> +            my $lastprint = -1;
> +            my $written;
> +

[snip]