Re: [PATCH ha-manager 2/2] fix #6084: lrm: allow dropping maintenance with active HA resources

["Michael Köppl" <m.koeppl@proxmox.com>]

1 nit inline

On Wed Jul 8, 2026 at 10:42 AM CEST, Daniel Kral wrote:

[snip]

> +++ b/src/PVE/HA/LRM.pm
> @@ -456,13 +456,16 @@ sub work {
>              $haenv->release_ha_agent_lock();
>              give_up_watchdog_protection($self);
>              $self->set_local_status({ state => 'wait_for_agent_lock' });
> -        } elsif ($self->active_service_count() || $self->run_workers()) {
> +        } elsif (
> +            ($self->active_service_count() || $self->run_workers())
> +            && $self->is_maintenance_requested()
> +        ) {
>              # keep the lock and watchdog as long as not all services cleared the node

nit: this comment could perhaps also mention something like "while
there is a maintenance request"

>              if (!$self->get_protected_ha_agent_lock()) {
>                  $self->set_local_status({ state => 'lost_agent_lock' });
>              }
>          } elsif (!$self->is_maintenance_requested()) {
> -            # empty && no maintenance mode && not exited -> need to switch active again
> +            # no node maintenance request && not exited -> need to switch active again

[snip]