all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Max R. Carrara" <m.carrara@proxmox.com>
To: "Stoiko Ivanov" <s.ivanov@proxmox.com>, <pmg-devel@lists.proxmox.com>
Subject: Re: [PATCH pmg-gui v2 4/5] fix #3657: system options: add log-tracker-base textrow
Date: Wed, 10 Jun 2026 18:26:19 +0200	[thread overview]
Message-ID: <DJ5ID9MIJKZ1.3FZL4ZY9JUX1T@proxmox.com> (raw)
In-Reply-To: <20260609200637.904334-5-s.ivanov@proxmox.com>

On Tue Jun 9, 2026 at 10:04 PM CEST, Stoiko Ivanov wrote:
> the system options panel seems like the best place to set the location
> of the logs.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  js/SystemOptions.js | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/js/SystemOptions.js b/js/SystemOptions.js
> index 92dc5d0..b7d20fd 100644
> --- a/js/SystemOptions.js
> +++ b/js/SystemOptions.js
> @@ -91,6 +91,12 @@ Ext.define('PMG.SystemOptions', {
>              renderer: Ext.htmlEncode,
>          });
>
> +        me.add_text_row('log-tracker-base', gettext("Maillog base name"), {
> +            deleteEmpty: true,
> +            defaultValue: '/var/log/syslog',
> +            renderer: Ext.htmlEncode,
> +        });
> +

Even though it's kind of superfluous, perhaps the config option could be
greyed out or disabled in some way if the currently logged in user isn't
root@pam? Only a small thing though -- which probably depends on
personal taste as well -- so no hard feelings if this stays as it is.

>          me.add_proxy_row('http_proxy', gettext('HTTP proxy'));
>
>          me.add_textareafield_row('consent-text', gettext('Consent Text'), {





  reply	other threads:[~2026-06-10 16:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 20:04 [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable Stoiko Ivanov
2026-06-09 20:04 ` [PATCH pmg-api v2 1/5] config: add root_only paramter option Stoiko Ivanov
2026-06-10 16:26   ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-api v2 2/5] config: add log-tracker-base key Stoiko Ivanov
2026-06-10 16:26   ` Max R. Carrara
2026-06-09 20:04 ` [PATCH pmg-api v2 3/5] fix #3657: api: tracking center: explicitly set input base from config Stoiko Ivanov
2026-06-09 20:04 ` [PATCH pmg-gui v2 4/5] fix #3657: system options: add log-tracker-base textrow Stoiko Ivanov
2026-06-10 16:26   ` Max R. Carrara [this message]
2026-06-09 20:04 ` [PATCH pmg-docs v2 5/5] pmg-log-tracker: mention that input-base can be configured via GUI Stoiko Ivanov
2026-06-10 16:26   ` Max R. Carrara
2026-06-10 16:26 ` [PATCH pmg-api/pmg-docs/pmg-gui v2 0/5] tracking-center: make input-base configurable Max R. Carrara
2026-06-12 17:43 ` superseded: " Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJ5ID9MIJKZ1.3FZL4ZY9JUX1T@proxmox.com \
    --to=m.carrara@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal