From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CF37A1FF146 for ; Tue, 26 May 2026 16:51:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1B294CE9; Tue, 26 May 2026 16:51:31 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 16:51:28 +0200 Message-Id: To: "Shannon Sterz" , Subject: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry X-Mailer: aerc 0.20.0 References: <20260526145041.509128-1-s.sterz@proxmox.com> In-Reply-To: <20260526145041.509128-1-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779807064050 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: E3V5ZKENLSXAMYZS3FF2JR44D3JFSVTE X-Message-ID-Hash: E3V5ZKENLSXAMYZS3FF2JR44D3JFSVTE X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ah sorry this is missing a v2 On Tue May 26, 2026 at 4:50 PM CEST, Shannon Sterz wrote: > * properly quote actions > * rephrase some tips slightly for clarity. > > Signed-off-by: Shannon Sterz > Reviewed-by: Lukas Wagner > --- > ui/src/configuration/subscription_keys.rs | 8 ++++---- > ui/src/configuration/subscription_registry.rs | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configura= tion/subscription_keys.rs > index 5f3e9aa..79776ab 100644 > --- a/ui/src/configuration/subscription_keys.rs > +++ b/ui/src/configuration/subscription_keys.rs > @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp { > .on_activate(link.change_view_callback(|_| Some(= ViewState::Add))), > ) > .tip(tr!( > - "Add one or more subscription keys to the pool; the = Assign step \ > + "Add one or more subscription keys to the pool; the = 'Assign' step \ > happens later." > )), > ) > @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp { > .on_activate(link.change_view_callback(|_| Some(= ViewState::Assign))), > ) > .tip(tr!( > - "Pin the selected key to a remote node; Apply Pendin= g pushes the \ > + "Pin the selected key to a remote node; 'Apply Pendi= ng' pushes the \ > assignment to the remote." > )), > ) > @@ -324,8 +324,8 @@ impl LoadableComponent for SubscriptionKeyGridComp { > .on_activate(move |_| cb.emit(())), > ) > .tip(tr!( > - "Propose a one-key-per-node assignment for nodes tha= t have no active \ > - subscription, then queue it pending Apply." > + "Propose a key assignment for nodes that have no act= ive subscription \ > + and queue its application." > )), > ); > } > diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/confi= guration/subscription_registry.rs > index 45d8ccc..60cc43e 100644 > --- a/ui/src/configuration/subscription_registry.rs > +++ b/ui/src/configuration/subscription_registry.rs > @@ -135,7 +135,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -= > Row { > .with_child(tr!("{n} pending push(es)", n =3D push_c= ount)), > ) > .tip(tr!( > - "{n} pool key(s) queued for push; Apply Pending will ins= tall them on the remote.", > + "{n} pool key(s) queued for push; 'Apply Pending' will i= nstall them on the remote.", > n =3D push_count, > )), > ); > @@ -150,7 +150,7 @@ fn pending_badge(push_count: u32, clear_count: u32) -= > Row { > .with_child(tr!("{n} pending clear(s)", n =3D clear_= count)), > ) > .tip(tr!( > - "{n} live subscription(s) queued for removal; Apply Pend= ing will free them.", > + "{n} live subscription(s) queued for removal; 'Apply Pen= ding' will free them.", > n =3D clear_count, > )), > ); > @@ -739,7 +739,7 @@ fn key_cell(n: &RemoteNodeStatus) -> Html { > .with_child(text), > ) > .tip(tr!( > - "Not in pool - Adopt Key imports this live subscript= ion." > + "Not in pool - 'Adopt Key' imports this live subscri= ption." > )) > .into() > } else { > @@ -1374,7 +1374,7 @@ impl SubscriptionRegistryComp { > .on_activate(ctx.link().callback(|_| Msg::QueueClearForS= electedNode)), > ) > .tip(tr!( > - "Queue the selected node's live subscription for removal at = the next Apply Pending, \ > + "Queue the selected node's live subscription for removal at = the next 'Apply Pending', \ > freeing the key for reassignment. Available for a pool-mana= ged node; for a foreign \ > subscription, adopt it first." > )); > -- > 2.47.3