From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 84C5B1FF146 for ; Tue, 26 May 2026 16:39:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AFA9B4295; Tue, 26 May 2026 16:39:53 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 16:39:49 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager] ui: configuration: slightly clean up tool tips for subscrion registry From: "Lukas Wagner" To: "Shannon Sterz" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260526143027.482438-1-s.sterz@proxmox.com> In-Reply-To: <20260526143027.482438-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779806365254 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WGP3WKKR6KAAPDBNEMROLH5GP2MOBS2Y X-Message-ID-Hash: WGP3WKKR6KAAPDBNEMROLH5GP2MOBS2Y X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 26, 2026 at 4:30 PM CEST, Shannon Sterz wrote: > * properly quote actions > * rephrase some tips slightly for clarity. > > Signed-off-by: Shannon Sterz > --- > ui/src/configuration/subscription_keys.rs | 6 +++--- > ui/src/configuration/subscription_registry.rs | 8 ++++---- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/ui/src/configuration/subscription_keys.rs b/ui/src/configura= tion/subscription_keys.rs > index 5f3e9aa..c35a546 100644 > --- a/ui/src/configuration/subscription_keys.rs > +++ b/ui/src/configuration/subscription_keys.rs > @@ -286,7 +286,7 @@ impl LoadableComponent for SubscriptionKeyGridComp { > .on_activate(link.change_view_callback(|_| Some(= ViewState::Add))), > ) > .tip(tr!( > - "Add one or more subscription keys to the pool; the = Assign step \ > + "Add one or more subscription keys to the pool; the = 'Assign' step \ > happens later." > )), > ) > @@ -299,7 +299,7 @@ impl LoadableComponent for SubscriptionKeyGridComp { > .on_activate(link.change_view_callback(|_| Some(= ViewState::Assign))), > ) > .tip(tr!( > - "Pin the selected key to a remote node; Apply Pendin= g pushes the \ > + "Pin the selected key to a remote node; 'Apply Pendi= ng' pushes the \ > assignment to the remote." > )), > ) > @@ -325,7 +325,7 @@ impl LoadableComponent for SubscriptionKeyGridComp { > ) > .tip(tr!( > "Propose a one-key-per-node assignment for nodes tha= t have no active \ > - subscription, then queue it pending Apply." > + subscription, then queue applying it." > )), Maybe "Propose a key assignment for nodes that have no active subscription, allowing to queue it for applying the proposal later." could be a tad more clear? Although it might be a bit long for a tooltip... The remaining changes look good to me, I think quoting the 'action' looks nicer in the tooltip. Reviewed-by: Lukas Wagner