From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 88E4E1FF146 for ; Tue, 26 May 2026 11:50:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B888718A1E; Tue, 26 May 2026 11:50:33 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 26 May 2026 11:50:30 +0200 Message-Id: Subject: applied: [PATCH datacenter-manager] ui: snapshots: use constructor instead of custom `From` implementation From: "Lukas Wagner" To: "Dominik Csapak" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260526093123.1383837-1-d.csapak@proxmox.com> In-Reply-To: <20260526093123.1383837-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779789006327 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UMCVRXBMZCHH2WVKD3SGYUSZYIITD2SP X-Message-ID-Hash: UMCVRXBMZCHH2WVKD3SGYUSZYIITD2SP X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue May 26, 2026 at 11:31 AM CEST, Dominik Csapak wrote: > having it return a dialog when a specific property is set instead of an > embedded list is better done via a custom constructor. This way we don't > have to passthrough the properties of the dialog we need, we save the > extra property to differentiate, and the logic is not hidden inside the > `From` implementation. > > Signed-off-by: Dominik Csapak applied, thanks!