Re: [PATCH proxmox-geojson-data v3 1/1] initial commit

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri May 22, 2026 at 10:34 AM CEST, Dominik Csapak wrote:
> includes a make target to download the source shp/shx file and the
> make targets for building the geojson file and package.
>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  Makefile             | 92 ++++++++++++++++++++++++++++++++++++++++++++
>  debian/changelog     |  5 +++
>  debian/control       | 16 ++++++++
>  debian/copyright     | 29 ++++++++++++++
>  debian/rules         |  4 ++
>  debian/source/format |  1 +
>  6 files changed, 147 insertions(+)
>  create mode 100644 Makefile
>  create mode 100644 debian/changelog
>  create mode 100644 debian/control
>  create mode 100644 debian/copyright
>  create mode 100755 debian/rules
>  create mode 100644 debian/source/format
>
> diff --git a/Makefile b/Makefile
> new file mode 100644
> index 0000000..8a5cf9d
> --- /dev/null
> +++ b/Makefile
> @@ -0,0 +1,92 @@
> +include /usr/share/dpkg/default.mk
> +
> +PACKAGE=proxmox-geojson-data
> +
> +BUILDDIR ?= $(PACKAGE)-$(DEB_VERSION_UPSTREAM)
> +ORIG_SRC_TAR=$(PACKAGE)_$(DEB_VERSION_UPSTREAM).orig.tar.gz
> +
> +DEB=$(PACKAGE)_$(DEB_VERSION)_all.deb
> +DSC=$(PACKAGE)_$(DEB_VERSION).dsc
> +
> +DESTDIR =
> +PREFIX = /usr
> +OUTDIR = $(PREFIX)/share/$(PACKAGE)
> +

this is missing a `.PHONY: all`

> +all: world-map.json
> +
> +NE_REF   := v5.1.2
> +NE_DEST  := assets
> +NE_BASE  := https://raw.githubusercontent.com/nvkelso/natural-earth-vector/$(NE_REF)
> +NE_FILE  := ne_110m_admin_0_countries
> +NE_FILES := \
> +    $(NE_FILE).shp \
> +    $(NE_FILE).shx \
> +
> +NE_TARGETS := $(addprefix $(NE_DEST)/,$(NE_FILES))
> +
> +SQL_COMMAND := "SELECT 'land' AS kind, ST_Union(geometry) AS geometry FROM $(NE_FILE) UNION ALL SELECT 'borders' AS kind, ST_Collect(ST_Boundary(geometry)) AS geometry FROM $(NE_FILE)"
> +
> +.PHONY: natural-earth natural-earth-clean
> +natural-earth: $(NE_TARGETS)
> +
> +$(NE_DEST)/%: | $(NE_DEST)
> +	curl -fsSL --retry 3 -o $@ $(NE_BASE)/110m_cultural/$*
> +
> +$(NE_DEST):
> +	mkdir -p $@
> +
> +natural-earth-clean:
> +	rm -f $(NE_TARGETS)
> +
> +world-map.json: $(NE_TARGETS)
> +	ogr2ogr -f "GeoJSON" world-map.json $(NE_DEST)/ne_110m_admin_0_countries.shp -dialect sqlite -sql $(SQL_COMMAND) -lco COORDINATE_PRECISION=4 -nlt MULTILINESTRING
> +
> +install: world-map.json
> +	install -dm0755 $(DESTDIR)$(OUTDIR)
> +	install -m0644 world-map.json $(DESTDIR)$(OUTDIR)
> +
> +
> +$(BUILDDIR):

`$(NE_DEST)` should be a prerequisite here; otherwise building this
without running `all` first will fail on a git-clean repository

> +	rm -rf $@ $@.tmp
> +	mkdir -p $@.tmp/
> +	cp -a debian/ assets/ Makefile $@.tmp/

maybe `assets/` should be `$(NE_DEST)`

> +	echo "git clone git://git.proxmox.com/git/$(PACKAGE).git\\ngit checkout $$(git rev-parse HEAD)" \
> +	    > $@.tmp/debian/SOURCE
> +	mv $@.tmp $@

-->8 snip 8<--