From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 386631FF13F for ; Thu, 21 May 2026 14:10:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6CC0111EA; Thu, 21 May 2026 14:10:20 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 21 May 2026 14:09:46 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager/installer/proxmox/yew-comp v4 00/40] add auto-installer integration To: "Lukas Wagner" , "Christoph Heiss" , X-Mailer: aerc 0.20.0 References: <20260430124712.1614305-1-c.heiss@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779365369637 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PSTBTBZSRUBKGZWMG6T3B3GPYE3WQUAY X-Message-ID-Hash: PSTBTBZSRUBKGZWMG6T3B3GPYE3WQUAY X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed May 20, 2026 at 11:28 AM CEST, Lukas Wagner wrote: > On Thu Apr 30, 2026 at 2:46 PM CEST, Christoph Heiss wrote: >> This series adds integration with our automated installer [0] for all >> our products. With this, Proxmox Datacenter Manager can be used for >> serving answer files via HTTPS in an automated fashion. >> >> It provides three panels under the "Automated Installations" tab in the >> "Remotes" menu: >> >> - Automated Installations: List all past and currently ongoing >> installations. >> - Prepared Answers: Enables users to do the whole CRUD cycle for >> prepared answers, i.e. create new answers (from scratch or based on >> existing ones), edit and delete. >> - Authentication Tokens: Simple token for the /answer endpoint. What >> tokens can be used to obtain which answer can be set when editing a >> prepared answer under the "Authentication" tab. >> >> When a new token was created, either through the dedicated panel or >> directly while creating a new prepared answer, the secret itself as well >> as the command line for preparing an installation ISO is shown in the >> UI. > > This was already applied, but I'll leave feedback here nevertheless, I > tested the latest version from the current master branch. > > Bugs: > - "Advanced" checkbox is not visible when creating a new prepared > answer, only when editing an existing one > > - When editing an existing Prepared Answer and when changing the > Filesystem, the fields in the 'Advanced' section are not switched out > (e.g. when going from ext4 to ZFS, one still sees the LVM fields > instead of the ZFS specific ones) -> saving the filesystem change and > reopening the dialog shows the correct fields, as an intermediate > workaround > > - The commandline shown after creating a Prepared Answer does not > include the full API path necessary, only the base URL. Also seems to > be missing the fingerprint. > > - Seems like the "cards" do not really resize dynamically. Some columns > could probably be also a bit narrower, e.g. "Product" in the > "installations" card, or the "ID" column for the prepared > installations. > > UX: > > - The panels have a hard time fitting smaller screens (e.g. 1440x900). > Maybe we need to change the layout a bit (probably after the release, > no need to rush this now IMO). > > - The 'Prepared Answer' wizard could already validate the "Default > Answer" XOR Target Filters condition when pressing "Next", not only on > final submit > > - The 'check mark / x' columns for 'Prepared Answers > Default' and > 'Authentication Tokens > Enabled' should be centered. Also, in PVE and > PBS we tend to use '-' when something is disabled, not 'x' > > - For the 'Root Password' field, the empty text when editing an existing > Answer is 'Keep current' -- usually we use 'Unchanged' here, I think. > Just a tiny nitpick, but I thought I'd mention it nonetheless. > > Potential followups: > > - The "Prepared Answers" could use a Comment field > > - Maybe as a future follow-up for 'Target Filters': Add a couple > pre-defined filters that can be added easily (example: only match a > certain product, e.g. PVE) one things that seemingly wasn't mentioned here is that the FQDN is prefiled with `host.example.com` and nothing will urge you to change that. so if a users mises that, all their hosts will become "host.example.com", maybe we should at least treat it like the email in the "Global options" tab. alternatively, we should choose something that uses the default template variable. this would have two advantages: a) show how templating works here b) at least provide distinct host names across multiple installs.