From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Christoph Heiss" <c.heiss@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager/installer/proxmox/yew-comp v4 00/40] add auto-installer integration
Date: Wed, 20 May 2026 11:28:58 +0200 [thread overview]
Message-ID: <DINECA4MBNKD.ZN4DEKG5QNYV@proxmox.com> (raw)
In-Reply-To: <20260430124712.1614305-1-c.heiss@proxmox.com>
On Thu Apr 30, 2026 at 2:46 PM CEST, Christoph Heiss wrote:
> This series adds integration with our automated installer [0] for all
> our products. With this, Proxmox Datacenter Manager can be used for
> serving answer files via HTTPS in an automated fashion.
>
> It provides three panels under the "Automated Installations" tab in the
> "Remotes" menu:
>
> - Automated Installations: List all past and currently ongoing
> installations.
> - Prepared Answers: Enables users to do the whole CRUD cycle for
> prepared answers, i.e. create new answers (from scratch or based on
> existing ones), edit and delete.
> - Authentication Tokens: Simple token for the /answer endpoint. What
> tokens can be used to obtain which answer can be set when editing a
> prepared answer under the "Authentication" tab.
>
> When a new token was created, either through the dedicated panel or
> directly while creating a new prepared answer, the secret itself as well
> as the command line for preparing an installation ISO is shown in the
> UI.
This was already applied, but I'll leave feedback here nevertheless, I
tested the latest version from the current master branch.
Bugs:
- "Advanced" checkbox is not visible when creating a new prepared
answer, only when editing an existing one
- When editing an existing Prepared Answer and when changing the
Filesystem, the fields in the 'Advanced' section are not switched out
(e.g. when going from ext4 to ZFS, one still sees the LVM fields
instead of the ZFS specific ones) -> saving the filesystem change and
reopening the dialog shows the correct fields, as an intermediate
workaround
- The commandline shown after creating a Prepared Answer does not
include the full API path necessary, only the base URL. Also seems to
be missing the fingerprint.
- Seems like the "cards" do not really resize dynamically. Some columns
could probably be also a bit narrower, e.g. "Product" in the
"installations" card, or the "ID" column for the prepared
installations.
UX:
- The panels have a hard time fitting smaller screens (e.g. 1440x900).
Maybe we need to change the layout a bit (probably after the release,
no need to rush this now IMO).
- The 'Prepared Answer' wizard could already validate the "Default
Answer" XOR Target Filters condition when pressing "Next", not only on
final submit
- The 'check mark / x' columns for 'Prepared Answers > Default' and
'Authentication Tokens > Enabled' should be centered. Also, in PVE and
PBS we tend to use '-' when something is disabled, not 'x'
- For the 'Root Password' field, the empty text when editing an existing
Answer is 'Keep current' -- usually we use 'Unchanged' here, I think.
Just a tiny nitpick, but I thought I'd mention it nonetheless.
Potential followups:
- The "Prepared Answers" could use a Comment field
- Maybe as a future follow-up for 'Target Filters': Add a couple
pre-defined filters that can be added easily (example: only match a
certain product, e.g. PVE)
next prev parent reply other threads:[~2026-05-20 9:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 12:46 [PATCH datacenter-manager/installer/proxmox/yew-comp v4 00/40] add auto-installer integration Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 01/40] api-macro: allow $ in identifier name Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 02/40] schema: oneOf: allow single string variant Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 03/40] schema: implement UpdaterType for HashMap and BTreeMap Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 04/40] network-types: move `Fqdn` type from proxmox-installer-common Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 05/40] network-types: implement api type for Fqdn Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 06/40] network-types: add api wrapper type for std::net::IpAddr Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 07/40] network-types: cidr: implement generic `IpAddr::new` constructor Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 08/40] network-types: fqdn: implement standard library Error for Fqdn Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 09/40] node-status: make KernelVersionInformation Clone + PartialEq Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 10/40] installer-types: add common types used by the installer Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 11/40] installer-types: add types used by the auto-installer Christoph Heiss
2026-04-30 12:46 ` [PATCH proxmox v4 12/40] installer-types: implement api type for all externally-used types Christoph Heiss
2026-04-30 12:46 ` [PATCH yew-comp v4 13/40] widget: kvlist: add widget for user-modifiable data tables Christoph Heiss
2026-05-05 11:11 ` Dominik Csapak
2026-05-05 12:12 ` Dominik Csapak
2026-04-30 12:46 ` [PATCH datacenter-manager v4 14/40] api-types, cli: use ReturnType::new() instead of constructing it manually Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 15/40] api-types: add api types for auto-installer integration Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 16/40] config: add auto-installer configuration module Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 17/40] acl: wire up new /system/auto-installation acl path Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 18/40] server: api: add auto-installer integration module Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 19/40] server: api: auto-installer: add access token management endpoints Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 20/40] client: add bindings for auto-installer endpoints Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 21/40] ui: auto-installer: add installations overview panel Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 22/40] ui: auto-installer: add prepared answer configuration panel Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 23/40] ui: auto-installer: add access token " Christoph Heiss
2026-04-30 12:46 ` [PATCH datacenter-manager v4 24/40] docs: add documentation for auto-installer integration Christoph Heiss
2026-04-30 12:46 ` [PATCH installer v4 25/40] install: iso env: use JSON boolean literals for product config Christoph Heiss
2026-04-30 12:46 ` [PATCH installer v4 26/40] common: http: allow passing custom headers to post() Christoph Heiss
2026-04-30 12:46 ` [PATCH installer v4 27/40] common: http: retrieve error message from body on post() Christoph Heiss
2026-04-30 12:46 ` [PATCH installer v4 28/40] common: options: move regex construction out of loop Christoph Heiss
2026-04-30 12:46 ` [PATCH installer v4 29/40] assistant: support adding an authorization token for HTTP-based answers Christoph Heiss
2026-04-30 12:46 ` [PATCH installer v4 30/40] post-hook: run cargo fmt Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 31/40] tree-wide: used moved `Fqdn` type to proxmox-network-types Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 32/40] tree-wide: use `Cidr` type from proxmox-network-types Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 33/40] tree-wide: switch to filesystem types from proxmox-installer-types Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 34/40] auto: sysinfo: switch to " Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 35/40] fetch-answer: " Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 36/40] fetch-answer: http: prefer json over toml for answer format Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 37/40] fetch-answer: send auto-installer HTTP authorization token if set Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 38/40] fetch-answer: print full error messages when fetching failed Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 39/40] tree-wide: switch out `Answer` -> `AutoInstallerConfig` types Christoph Heiss
2026-04-30 12:47 ` [PATCH installer v4 40/40] auto: drop now-dead answer file definitions Christoph Heiss
2026-05-06 23:30 ` partially-applied: [PATCH datacenter-manager/installer/proxmox/yew-comp v4 00/40] add auto-installer integration Thomas Lamprecht
2026-05-07 2:25 ` Thomas Lamprecht
2026-05-07 3:11 ` applied: " Thomas Lamprecht
2026-05-20 9:28 ` Lukas Wagner [this message]
2026-05-21 12:09 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DINECA4MBNKD.ZN4DEKG5QNYV@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.