Re: applied: [PATCH-SERIES ha-manager 0/2] make idle LRMs resolve leftover moving HA resources while disarmed

["Daniel Kral" <d.kral@proxmox.com>]

On Tue May 19, 2026 at 10:11 PM CEST, Thomas Lamprecht wrote:
> On Tue, 19 May 2026 16:38:34 +0200, Daniel Kral wrote:
>> As in patch message #2:
>> 
>> If there are HA resources, which are in transient states that defer the
>> disarming process, but their LRMs are already in idle state and disarmed
>> mode, these LRMs will not properly resolve the transient states of these
>> HA resources as assumed by the HA Manager.
>> 
>> [...]
>
> Applied, thanks!
>
> Squashed Fiona's naming nits (disarm_deferring) into 2/2, added a contract doc
> on the new Tools helper, and dropped the unused $target_node destructuring and
> !$current_node guard while at it.

Thanks!

I started out also making disarmed LRMs active if an HA resource's
$target_node eq $node, but this wasn't required as the successful
migration is already confirmed by the $sd->{node} entry alone, which is
gathered from the pmxcfs itself, so no need to make the receiving LRM
active for that.

The !$current_node guard might still be worth (see my reply to Fiona's
review on patch 2/2) to be defensive against some edge cases.

>
> As I looked into this too a bit, and seemingly went for a different angle, I
> added a follow-up to also freeze non-deferred services on the deferred cycle,
> otherwise any LRM restart in the meantime (apt upgrade, manual restart) hangs
> in 'restart' mode waiting for an active_service_count going to zero that due to
> the deferred-mode CRM won't happen.

Thanks for the follow-ups and good catch that the frozen HA resources
are also accounted for the {basic,static} load accounting, good to have
a test cases for that! I'll also take more care to test with the other
shutdown modes in production!

>
> Bumped to 5.2.4.
>
> [1/2] test: add disarm test cases for idle lrms with transient ha resources
>       commit: 54497ae43d5bdb3842eb6f32e0642da9deb7cf5b
> [2/2] make idle LRMs resolve leftover moving HA resources while disarmed
>       commit: 9917559d01e60cc55622102bef2b8f5d87892d33