Re: [PATCH ha-manager 2/2] make idle LRMs resolve leftover moving HA resources while disarmed

["Daniel Kral" <d.kral@proxmox.com>]

On Tue May 19, 2026 at 6:00 PM CEST, Fiona Ebner wrote:
> Am 19.05.26 um 4:39 PM schrieb Daniel Kral:
>> If there are HA resources, which are in transient states that defer the
>> disarming process, but their LRMs are already in idle state and disarmed
>> mode, these LRMs will not properly resolve the transient states of these
>> HA resources as assumed by the HA Manager.
>> 
>> For HA resources, which are still moving, this makes the HA Manager
>> stuck in a loop, which tries to defer the disarming process to wait for
>> a LRM response for these moving HA resources, which will never come as
>> the LRM is idle.
>> 
>> Therefore allow the LRM to become active in disarm mode if there are any
>> HA resources on the LRM's node, which are in any of these transient
>> states, and make sure that the LRM only processes the disarm-deferring
>> HA resources while the LRM is active.
>> 
>> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
>> ---
>>  src/PVE/HA/LRM.pm                         | 19 ++++++++++-
>>  src/PVE/HA/Manager.pm                     |  8 ++---
>>  src/PVE/HA/Tools.pm                       | 17 ++++++++++
>>  src/test/test-disarm-idle-lrm1/log.expect | 37 ++++++---------------
>>  src/test/test-disarm-idle-lrm2/log.expect | 39 +++++++----------------
>>  5 files changed, 58 insertions(+), 62 deletions(-)
>> 
>> diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
>> index 426982cc..9100d611 100644
>> --- a/src/PVE/HA/LRM.pm
>> +++ b/src/PVE/HA/LRM.pm
>> @@ -312,6 +312,18 @@ sub active_service_count {
>>      return PVE::HA::Tools::count_active_services($ss, $nodename);
>>  }
>>  
>> +# returns a truthy value if there are HA resources in transient states, which
>> +# need to be resolved, e.g. to complete the disarm procedure.
>> +sub has_disarm_deferred_services {
>
> Nit: I feel like the variables and functions should rather be named
> disarm_deferring rather than disarm_deferred

Thanks for the review, agree with all the renames!

[snip]

>> diff --git a/src/PVE/HA/Tools.pm b/src/PVE/HA/Tools.pm
>> index 26629fb5..37b27e11 100644
>> --- a/src/PVE/HA/Tools.pm
>> +++ b/src/PVE/HA/Tools.pm
>> @@ -213,6 +213,23 @@ sub count_active_services {
>>      return $active_count;
>>  }
>>  
>> +sub get_disarm_deferred_services {
>> +    my ($ss, $node) = @_;
>> +
>> +    my $deferred_sids = {};
>> +    my @deferrable_states = qw(fence recovery migrate relocate);
>
> Nit: disarm_deferring_states
>
>> +
>> +    for my $sid (keys %$ss) {
>> +        my ($state, $current_node, $target_node) = $ss->{$sid}->@{qw(state node target)};
>> +
>> +        next if $node && (!$current_node || $current_node ne $node);
>
> Just wondering: when does !$current_node happen?

AFAIK the only case where this can currently happen is if the HA
resource's guest doesn't exist in the cluster anymore according to the
pmxcfs' vmlist and isn't removed by HA Manager anymore (as is done when
the HA stack is in disarm mode).

>
>> +
>> +        $deferred_sids->{$sid} = 1 if grep { $state eq $_ } @deferrable_states;
>> +    }
>> +
>> +    return $deferred_sids;
>> +}
>> +
>>  sub get_verbose_service_state {
>>      my ($service_state, $service_conf) = @_;
>>