Re: [PATCH manager v4] ui: ha: add disarm/re-arm button

["Dominik Rusovac" <d.rusovac@proxmox.com>]

thx for taking the time

will send a v5

On Wed May 13, 2026 at 3:16 PM CEST, Christoph Heiss wrote:
> On Wed May 13, 2026 at 10:11 AM CEST, Dominik Rusovac wrote:
>> The button to disarm HA in either of the resource modes ('freeze' or
>> 'ignore') is disabled as long as HA is disarmed. Analogously, the button
>> to arm HA is disabled as long as HA is not disarmed.
>>
>> For feedback, after clicking either of the buttons, icon spins as long as
>> (dis)arming process has not changed the armed-state of HA.
>>
>> The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA"
>> and "Arm HA" are complements. There may be more suitable pairs of icons
>> though.
>
> Just a suggestion, no hard feelings, looking at the icons, maybe some
> other suitable icon pairs could also be:
>   - 'pause-circle-o' and 'play-circle-o' or
>   - 'lock' and 'unlock-alt'?

nice suggestions, thx! 

no hard feelings on my side either. we can definitely go for 
either of your suggestions. what do the others think?

>
> Didn't review *too* closely besides my two inline comments.
>
> Tested it though, works as advertised.
>
> Tested-by: Christoph Heiss <c.heiss@proxmox.com>
>
> [..]
>> index b0b0feb9..86df8b31 100644
>> --- a/www/manager6/ha/Status.js
>> +++ b/www/manager6/ha/Status.js
>> @@ -8,6 +8,113 @@ Ext.define('PVE.ha.Status', {
>>          align: 'stretch',
>>      },
>>
>> +    viewModel: {
>> +        data: {
>> +            haDisarmed: false,
>> +        },
>> +    },
>> +
>> +    controller: {
>> +        xclass: 'Ext.app.ViewController',
>> +
>> +        handleDisarmButton: function (menuItem) {
>> +            let me = this;
>> +            let view = me.getView();
>> +
>> +            let warn = Ext.String.format(
>> +                gettext("Are you sure you want to disarm HA with resource mode '{0}'?"),
>> +                menuItem.text,
>> +            );
>> +
>> +            let details =
>> +                'While disarmed, HA does not protect your services. Failures during this period are not automatically recovered.';
>
> This won't get picked up by `xgettext`, needs to be wrapped in
> `gettext()` directly.
>

ack, thx!

>> +
>> +            Ext.Msg.confirm(
>> +                gettext('Confirm'),
>> +                warn + '<br><br>' + gettext(menuItem.details) + '<br><br>' + gettext(details),
>                                        ^^^^^^^^^^^^^^^^^^^^^^^^^
> `menuItem.details` is already the translated string, no?
> Since below definitions already wrap it accordingly.

true, sloppiness on my side 

ack, thx for the heads up