Re: [PATCH datacenter-manager v2 6/8] cli: add subscription key pool management subcommands

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu May 7, 2026 at 10:26 AM CEST, Thomas Lamprecht wrote:
> Expose the new key-pool API to the CLI so that the subscriptions
> command group gains the following sub commands:
>
>   list-keys
>   add-keys (variadic)
>   assign-key
>   clear-key
>   remove-key
>   auto-assign
>   apply-pending
>   clear-pending
>
> The pre-existing `status` subcommand becomes a sibling under this
> `subscriptions` group.

Looks good to me in general. Maybe I've missed it, but it does not seem
that I can see which keys/nodes are pending in the CLI?

One further note inline.

Otherwise:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

>
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> ---
>  cli/client/src/subscriptions.rs | 195 +++++++++++++++++++++++++++++++-
>  lib/pdm-client/src/lib.rs       | 126 ++++++++++++++++++++-
>  2 files changed, 316 insertions(+), 5 deletions(-)
>

[...]

> +
> +#[api]
> +/// Push all pending key assignments to remotes as a worker task.
> +async fn apply_pending() -> Result<(), Error> {
> +    match client()?.subscription_apply_pending().await? {
> +        None => println!("No pending assignments to apply."),
> +        Some(upid) => println!("Task started: {upid}"),
> +    }
> +    Ok(())
> +}

I guess this should at least wait for the task to finish? At least
that's what we usually do, see for example `remote_migrate_qemu` in
pve.rs

Streaming the task logs to the CLI would be even nicer, not sure if we
do this anywhere yet though.

> +
> +#[api]
> +/// Clear every pending assignment in one bulk transaction.
> +async fn clear_pending() -> Result<(), Error> {
> +    let cleared = client()?.subscription_clear_pending().await?;
> +    if cleared == 0 {
> +        println!("No pending assignments to clear.");
> +    } else {
> +        println!("Cleared {cleared} pending assignment(s).");
> +    }
> +    Ok(())
> +}