From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-ha-manager 2/3] manager: set service config value in self
Date: Tue, 12 May 2026 13:55:45 +0200 [thread overview]
Message-ID: <DIGOGB5P4FHN.32JGRZH06ZC7B@proxmox.com> (raw)
In-Reply-To: <DIGKUIL9KIXT.1Q88CZJSWGEP@proxmox.com>
thx for taking the time, will resolve the nits in v2
On Tue May 12, 2026 at 11:06 AM CEST, Daniel Kral wrote:
> Looks good to me, left a few nits inline, with those resolved consider
> this patch as:
>
> Reviewed-by: Daniel Kral <d.kral@proxmox.com>
>
> On Mon May 11, 2026 at 5:57 PM CEST, Dominik Rusovac wrote:
>> This is in preparation for the follow-up patch.
>>
>> Reading the value of 'auto-rebalance'-flag in the service config of an
>> HA resource is required to perform proper resource bundling.
>>
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>> src/PVE/HA/Manager.pm | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
[snip]
next prev parent reply other threads:[~2026-05-12 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 15:57 [PATCH-SERIES ha-manager/manager 0/3] fix #7557: introduce 'auto-rebalance' property Dominik Rusovac
2026-05-11 15:57 ` [PATCH pve-manager 1/3] ui: ha: add auto-rebalance flag Dominik Rusovac
2026-05-12 9:05 ` Daniel Kral
2026-05-11 15:57 ` [PATCH pve-ha-manager 2/3] manager: set service config value in self Dominik Rusovac
2026-05-12 9:06 ` Daniel Kral
2026-05-12 11:55 ` Dominik Rusovac [this message]
2026-05-11 15:57 ` [PATCH pve-ha-manager 3/3] fix #7557: introduce 'auto-rebalance' property Dominik Rusovac
2026-05-12 9:07 ` Daniel Kral
2026-05-12 11:51 ` Dominik Rusovac
2026-05-12 9:21 ` [PATCH-SERIES ha-manager/manager 0/3] " Daniel Kral
2026-05-12 11:53 ` Dominik Rusovac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIGOGB5P4FHN.32JGRZH06ZC7B@proxmox.com \
--to=d.rusovac@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.