From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C48CE1FF13F for ; Thu, 07 May 2026 15:23:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 857C81CF30; Thu, 7 May 2026 15:23:34 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Thu, 07 May 2026 15:23:30 +0200 Message-Id: Subject: Re: [PATCH datacenter-manager v2 2/8] api types: subscription level: render full names From: "Lukas Wagner" To: "Thomas Lamprecht" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260507082943.2749725-1-t.lamprecht@proxmox.com> <20260507082943.2749725-3-t.lamprecht@proxmox.com> In-Reply-To: <20260507082943.2749725-3-t.lamprecht@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778160102431 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EIMCP5IJ6C6K37VHKF2L5SRE3VTCYUCH X-Message-ID-Hash: EIMCP5IJ6C6K37VHKF2L5SRE3VTCYUCH X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu May 7, 2026 at 10:26 AM CEST, Thomas Lamprecht wrote: > The Display impl produced single-letter codes ("c", "b", "s", "p"), > forcing the dashboard to keep a private letter-to-name helper just > to render labels. > > Switching Display to the full names is safe: FromStr is extended to > accept the names alongside the legacy single-letter codes, so any > previously serialised value still parses, and the only in-tree > caller of Display on this enum is the dashboard helper that this > commit drops. The level strings reported by the PVE/PBS API land in > unrelated String fields and are not touched. > > Add Debug to the derives, required for assert_eq! over the level in > the upcoming key-pool tests. > Reviewed-by: Lukas Wagner