From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E5FBA1FF13A for ; Wed, 29 Apr 2026 09:58:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 94B6F21C59; Wed, 29 Apr 2026 09:58:45 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Apr 2026 09:58:36 +0200 Message-Id: Subject: Re: [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function From: "Shan Shaji" To: "Shan Shaji" , X-Mailer: aerc 0.20.0 References: <20260421121212.218008-1-s.shaji@proxmox.com> In-Reply-To: <20260421121212.218008-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777449419001 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: BJGCCDC4SOJ3DR2X6CI2VK2R2TLK326M X-Message-ID-Hash: BJGCCDC4SOJ3DR2X6CI2VK2R2TLK326M X-MailFrom: s.shaji@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: update: user has confirmed that the fix works. https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decod= e-command-not-found.182899/post-849477 On Tue Apr 21, 2026 at 2:12 PM CEST, Shan Shaji wrote: > While placing the ACME certificate order using the Active24 plugin, > the request was failing [0]. This was because, `_json_decode` function > was referenced inside the dns_active24.sh file but was never defined > in the `proxmox-acme` script.To fix it, the missing function was added > by referencing the implementation from the acme.sh [1] script. > > - [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-js= on_decode-command-not-found.182899/ > - [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912 > > Signed-off-by: Shan Shaji > --- > > **note**: I couldn't test the changes as i don't have Active24 credentia= ls. > =20 > src/proxmox-acme | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/src/proxmox-acme b/src/proxmox-acme > index 9eea590..499d533 100644 > --- a/src/proxmox-acme > +++ b/src/proxmox-acme > @@ -913,6 +913,14 @@ _source_plugin_config() { > return 0 > } > =20 > +# from: http:\/\/ to http:// > +_json_decode() { > + _j_str=3D"$(sed 's#\\/#/#g')" > + _debug3 "_json_decode" > + _debug3 "_j_str" "$_j_str" > + echo "$_j_str" > +} > + > # Proxmox implementation to inject the DNSAPI variables > _load_plugin_config() { > while IFS=3D read -r line; do