From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 63D701FF13A for ; Wed, 29 Apr 2026 09:48:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3465D2155D; Wed, 29 Apr 2026 09:48:31 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 29 Apr 2026 09:48:26 +0200 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH pve-cluster 7/7] datacenter config: add maxima for load scheduler options From: "Dominik Rusovac" X-Mailer: aerc 0.20.0 References: <20260427132031.220468-1-d.rusovac@proxmox.com> <20260427132031.220468-8-d.rusovac@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777448809415 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.427 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datacenterconfig.pm] Message-ID-Hash: QAABNQOKJZ5WRXAKN55CVJ3O4UMIP7MT X-Message-ID-Hash: QAABNQOKJZ5WRXAKN55CVJ3O4UMIP7MT X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Apr 28, 2026 at 10:53 AM CEST, Daniel Kral wrote: > On Mon Apr 27, 2026 at 3:20 PM CEST, Dominik Rusovac wrote: >> Signed-off-by: Dominik Rusovac >> --- >> src/PVE/DataCenterConfig.pm | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm >> index 6513594..d120017 100644 >> --- a/src/PVE/DataCenterConfig.pm >> +++ b/src/PVE/DataCenterConfig.pm >> @@ -44,6 +44,7 @@ EODESC >> type =3D> 'number', >> optional =3D> 1, >> minimum =3D> 0.0, >> + maximum =3D> 1.0, >> default =3D> 0.3, >> requires =3D> 'ha-auto-rebalance', >> description =3D> "The threshold for the cluster node imbalance,= which will" >> @@ -72,6 +73,7 @@ EODESC >> type =3D> 'number', >> optional =3D> 1, >> minimum =3D> 0.0, >> + maximum =3D> 1.0, > > Oh right, this should have already been there before as reducing the > imbalance by more than 100 % makes no sense ;-). > >> default =3D> 0.1, >> requires =3D> 'ha-auto-rebalance', >> description =3D> "The minimum relative improvement in cluster n= ode" > > nit: would be nice to have some patch message here too why those changes > are fine to make it a little more explicit and the changes to margin > syncs with what is already done in the web interface AFAICT. ack, will add text