From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 88C671FF146 for ; Tue, 28 Apr 2026 11:20:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B256C0B7; Tue, 28 Apr 2026 11:20:32 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 28 Apr 2026 11:20:27 +0200 Message-Id: Subject: Re: [PATCH pve-ha-manager 5/7] manager: add load imbalance to status From: "Daniel Kral" To: "Dominik Rusovac" , X-Mailer: aerc 0.21.0-136-gdb9fe9896a79-dirty References: <20260427132031.220468-1-d.rusovac@proxmox.com> <20260427132031.220468-6-d.rusovac@proxmox.com> In-Reply-To: <20260427132031.220468-6-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777367931455 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manager.pm] Message-ID-Hash: JLVUC5ZC47A6UL7ZHBK4TZ7Q3UX4O344 X-Message-ID-Hash: JLVUC5ZC47A6UL7ZHBK4TZ7Q3UX4O344 X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Apr 27, 2026 at 3:20 PM CEST, Dominik Rusovac wrote: > Signed-off-by: Dominik Rusovac > --- > src/PVE/HA/Manager.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm > index b69a6bb..ba26fbf 100644 > --- a/src/PVE/HA/Manager.pm > +++ b/src/PVE/HA/Manager.pm > @@ -285,6 +285,7 @@ sub flush_master_status { > $ms->{node_status} =3D $ns->{status}; > $ms->{service_status} =3D $ss; > $ms->{timestamp} =3D $haenv->get_time(); > + $ms->{imbalance} =3D $self->{online_node_usage}->calculate_node_imba= lance(); Nice! This should allow some better look on the current state of the load balancer and how well it performs w.r.t. to the imbalance threshold. > =20 > $haenv->write_manager_status($ms); > } Consider as: Reviewed-by: Daniel Kral