all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Daniel Kral" <d.kral@proxmox.com>
To: "Dominik Rusovac" <d.rusovac@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-cluster 7/7] datacenter config: add maxima for load scheduler options
Date: Tue, 28 Apr 2026 10:53:01 +0200	[thread overview]
Message-ID: <DI4NSRG13211.2MMS24FNWW7CT@proxmox.com> (raw)
In-Reply-To: <20260427132031.220468-8-d.rusovac@proxmox.com>

On Mon Apr 27, 2026 at 3:20 PM CEST, Dominik Rusovac wrote:
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index 6513594..d120017 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -44,6 +44,7 @@ EODESC
>          type => 'number',
>          optional => 1,
>          minimum => 0.0,
> +        maximum => 1.0,
>          default => 0.3,
>          requires => 'ha-auto-rebalance',
>          description => "The threshold for the cluster node imbalance, which will"
> @@ -72,6 +73,7 @@ EODESC
>          type => 'number',
>          optional => 1,
>          minimum => 0.0,
> +        maximum => 1.0,

Oh right, this should have already been there before as reducing the
imbalance by more than 100 % makes no sense ;-).

>          default => 0.1,
>          requires => 'ha-auto-rebalance',
>          description => "The minimum relative improvement in cluster node"

nit: would be nice to have some patch message here too why those changes
are fine to make it a little more explicit and the changes to margin
syncs with what is already done in the web interface AFAICT.




  reply	other threads:[~2026-04-28  8:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 13:20 [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox 0/7] clamp load imbalance to unit interval Dominik Rusovac
2026-04-27 13:20 ` [PATCH proxmox 1/7] resource-scheduling: clamp imbalance value " Dominik Rusovac
2026-04-28  9:05   ` Daniel Kral
2026-04-27 13:20 ` [PATCH proxmox 2/7] resource-scheduling: re-adjust hardcoded imbalance values Dominik Rusovac
2026-04-28  8:53   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-manager 3/7] ui: from/CRSOptions: add maximum for threshold Dominik Rusovac
2026-04-28  8:52   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-ha-manager 4/7] test: re-adjust logged imbalance values Dominik Rusovac
2026-04-28  8:52   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-ha-manager 5/7] manager: add load imbalance to status Dominik Rusovac
2026-04-28  9:20   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-ha-manager 6/7] api: status: " Dominik Rusovac
2026-04-28  9:10   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-cluster 7/7] datacenter config: add maxima for load scheduler options Dominik Rusovac
2026-04-28  8:53   ` Daniel Kral [this message]
2026-04-28  9:21 ` [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox 0/7] clamp load imbalance to unit interval Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DI4NSRG13211.2MMS24FNWW7CT@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.rusovac@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal