From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 850C51FF146 for ; Tue, 28 Apr 2026 10:52:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F61FAF56; Tue, 28 Apr 2026 10:52:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 28 Apr 2026 10:52:04 +0200 Message-Id: From: "Daniel Kral" To: "Dominik Rusovac" , Subject: Re: [PATCH pve-manager 3/7] ui: from/CRSOptions: add maximum for threshold X-Mailer: aerc 0.21.0-136-gdb9fe9896a79-dirty References: <20260427132031.220468-1-d.rusovac@proxmox.com> <20260427132031.220468-4-d.rusovac@proxmox.com> In-Reply-To: <20260427132031.220468-4-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777366228132 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V2MMX7BZTFST3NYW35GIB4333XMX62X2 X-Message-ID-Hash: V2MMX7BZTFST3NYW35GIB4333XMX62X2 X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon Apr 27, 2026 at 3:20 PM CEST, Dominik Rusovac wrote: > Signed-off-by: Dominik Rusovac > --- > www/manager6/form/CRSOptions.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/form/CRSOptions.js b/www/manager6/form/CRSOptio= ns.js > index b5476bd5..985eb8cf 100644 > --- a/www/manager6/form/CRSOptions.js > +++ b/www/manager6/form/CRSOptions.js > @@ -66,6 +66,7 @@ Ext.define('PVE.form.CRSOptions', { > fieldLabel: gettext('Imbalance Threshold'), > emptyText: '0.3', > minValue: 0.0, > + maxValue: 1.0, > step: 0.01, > bind: { > disabled: '{!enableAutoRebalance.checked}', Nice! Could be irritating if users have already set this option to a value to something greater than 1.0, but as it's a very new feature and an undocumented setting, this shouldn't be that many users. Consider this as: Reviewed-by: Daniel Kral