Re: [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Apr 2, 2026 at 1:09 PM CEST, Dominik Csapak wrote:
>
>
> On 4/2/26 12:54 PM, Lukas Wagner wrote:
>> On Mon Mar 9, 2026 at 3:37 PM CET, Dominik Csapak wrote:
>>> Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply
>>> use the 'node' one, since there can only be one for PBS anyway.
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>> ---
>>>   ui/src/pbs/node/mod.rs | 12 +++++++++++-
>>>   1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
>>> index abb1f6a6..6d2f46b8 100644
>>> --- a/ui/src/pbs/node/mod.rs
>>> +++ b/ui/src/pbs/node/mod.rs
>>> @@ -17,7 +17,7 @@ pub(crate) mod overview;
>>>   
>>>   use overview::PbsNodeOverviewPanel;
>>>   
>>> -use crate::get_deep_url_low_level;
>>> +use crate::{get_deep_url_low_level, remotes::RemoteTaskList};
>>>   
>>>   #[derive(Clone, Debug, Eq, PartialEq, Properties)]
>>>   pub struct PbsNodePanel {
>>> @@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp {
>>>                       move |_| PbsNodeOverviewPanel::new(remote.clone()).into()
>>>                   },
>>>               )
>>> +            .with_item_builder(
>>> +                TabBarItem::new()
>>> +                    .key("tasks_view")
>>> +                    .label(tr!("Tasks"))
>>> +                    .icon_class("fa fa-list"),
>>> +                {
>>> +                    let remote = props.remote.clone();
>>> +                    move |_| RemoteTaskList::new().remote(remote.clone()).into()
>>> +                },
>>> +            )
>>>               .with_item_builder(
>>>                   TabBarItem::new()
>>>                       .key("update_view")
>> 
>> I wonder, should we also add a 'per-node' Tasks tab for PVE remotes?
>> What do you think?
>> 
>
> mhmm can make sense, but maybe a better option would be to add a node
> selector to the tasks on datacenter level? (maybe both?)

Yeah, that could also make sense, I think. The main reason I mentioned
it is consistency, I think the 'node' objects in the resource tree
should offer the same tabs for both, PVE and PBS, if sensible and
possible.

But anyways, I think this tab makes sense for PBS, so I'd go ahead and
apply this soonish.


>
> I just fear that we might overload the interface with too many options
> if we do this for everything (but that fear might be unfounded :P )