From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CB1191FF142 for ; Tue, 21 Apr 2026 12:26:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 392A61B727; Tue, 21 Apr 2026 12:26:26 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Apr 2026 12:25:50 +0200 Message-Id: Subject: Re: [PATCH access-control/manager/proxmox v4 0/3] fix #5076: add support for open id audiences To: "Shannon Sterz" , X-Mailer: aerc 0.20.0 References: <20260420153332.414620-1-s.sterz@proxmox.com> In-Reply-To: <20260420153332.414620-1-s.sterz@proxmox.com> From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776767065541 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com,zitadel.com,lib.rs,openid.pm] Message-ID-Hash: JO446XXFB72VGPBJ4UPGWPYNHPM5B74W X-Message-ID-Hash: JO446XXFB72VGPBJ4UPGWPYNHPM5B74W X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: just noticed that pbs/pdm will need adaption too to properly support this. sorry for missing that, will send an updated version. On Mon Apr 20, 2026 at 5:33 PM CEST, Shannon Sterz wrote: > this series adapts the original patch series by Alexander Abraham [1]. be= low is > the text of the original cover letter: > >> fix #5076: Added Open ID audiences >> >> This series adds support for handling Open ID audiences as described in = bug >> #5076. PVE's API schema was updated to accept an optional field, an arra= y of >> strings and the Rust code was also updated to accordingly handle any inc= oming >> audiences and compare them to the realm config's audiences. In the realm >> dialogue for adding an Open ID realm, a new field titled "Audiences" was= added >> so that users can save any audiences in their realm domains config file. > > essentially, some open id providers such as zitadel [1] may provide addit= ional > audiences that their id tokens are valid for instead of just the client i= d. > these patches allow setting such additional audiences. if an audience tha= t is > not explicitly allowed is encountered, the id token is rejected as before= . > > [1]: https://zitadel.com/ > > Changelog > --------- > > changes since the last public version of these patches > > * rebased on current master > * see the list of changes made by Shannon Sterz specified in each commit = message > > [1]: https://lore.proxmox.com/pve-devel/20250603091256.40923-1-a.abraham@= proxmox.com/ > > > proxmox: > > Shannon Sterz (1): > fix #5076: openid: add logic to handle OIDC audiences > > proxmox-openid/src/lib.rs | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > > proxmox: > > Shannon Sterz (1): > fix #5076: auth: open id: add an optional "audiences" field > > src/PVE/API2/OpenId.pm | 4 ++++ > src/PVE/Auth/OpenId.pm | 12 ++++++++++++ > 2 files changed, 16 insertions(+) > > > proxmox: > > Shannon Sterz (1): > fix #5076: ui: dc: add an optional "audiences" field for open id > realms > > www/manager6/dc/AuthEditOpenId.js | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > > Summary over all repositories: > 4 files changed, 48 insertions(+), 2 deletions(-)