all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH perl-rs] pve-rs: add proxmox-frr-templates to build dependency
Date: Tue, 21 Apr 2026 10:55:33 +0200	[thread overview]
Message-ID: <DHYPGW8LORDK.NUZB60AINZ7S@proxmox.com> (raw)
In-Reply-To: <DHYLNBPS8TGF.EAPLF5ACPJVE@proxmox.com>

On Tue Apr 21, 2026 at 7:55 AM CEST, Daniel Kral wrote:
> On Mon Apr 20, 2026 at 3:58 PM CEST, Shannon Sterz wrote:
>> otherwise, building will fails because the templates cannot be found
>> and statically included.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>  pve-rs/debian/control | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/pve-rs/debian/control b/pve-rs/debian/control
>> index 25e2121..27d455a 100644
>> --- a/pve-rs/debian/control
>> +++ b/pve-rs/debian/control
>> @@ -47,6 +47,7 @@ Build-Depends: debhelper-compat (= 13),
>>                 librust-url-2+default-dev,
>>                 libstd-rust-dev <!nocheck>,
>>                 perlmod-bin (>= 0.2.1-1),
>> +               proxmox-frr-templates,
>>                 rustc:native <!nocheck>,
>>  Maintainer: Proxmox Support Team <support@proxmox.com>
>>  Standards-Version: 4.6.1
>
> Good to have here as well, I've noticed it with my pve-rs patches as
> well and sent a patch [0] where I put it in the proxmox-frr package
> which makes it a transient dependency here :).
>
> [0] https://lore.proxmox.com/pve-devel/20260331090050.128253-1-d.kral@proxmox.com/

ah yeah that's probably preferable. sorry i missed your patch here, just
ran into this and wanted to clean it up while im at it :)




  reply	other threads:[~2026-04-21  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 13:58 Shannon Sterz
2026-04-21  5:55 ` Daniel Kral
2026-04-21  8:55   ` Shannon Sterz [this message]
2026-04-21 12:39 ` applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHYPGW8LORDK.NUZB60AINZ7S@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal