From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 41E631FF142 for ; Tue, 21 Apr 2026 10:12:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24D0417FB9; Tue, 21 Apr 2026 10:12:34 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Apr 2026 10:12:28 +0200 Message-Id: Subject: Re: [PATCH proxmox v3 01/23] Add oauth2 and ureq to workspace dependencies From: "Lukas Wagner" To: "Arthur Bied-Charreton" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260415070220.100306-1-a.bied-charreton@proxmox.com> <20260415070220.100306-2-a.bied-charreton@proxmox.com> In-Reply-To: <20260415070220.100306-2-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776759064141 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3TLSGYHPAB45V2CKJNH3YBXE3IUY4LM4 X-Message-ID-Hash: 3TLSGYHPAB45V2CKJNH3YBXE3IUY4LM4 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Arthur! Two notes inline, looks good otherwise. On Wed Apr 15, 2026 at 9:01 AM CEST, Arthur Bied-Charreton wrote: > Since oauth2 and ureq will be needed by proxmox-notify for XOAUTH2 > support, pull them in as workspace dependencies and update > proxmox-openid and proxmox-http accordingly. > > Signed-off-by: Arthur Bied-Charreton > --- > Cargo.toml | 2 ++ > proxmox-http/Cargo.toml | 2 +- > proxmox-openid/Cargo.toml | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Cargo.toml b/Cargo.toml > index cf49a8b0..ecc36d65 100644 > --- a/Cargo.toml > +++ b/Cargo.toml > @@ -119,6 +119,7 @@ nix =3D "0.29" > nom =3D "7" > # used by proxmox-disks, can be replaced by OnceLock from std once it su= pports get_or_try_init > once_cell =3D "1.3.1" > +oauth2 =3D { version =3D "5", default-features =3D false } > openssl =3D "0.10" > pam-sys =3D "0.5" > percent-encoding =3D "2.1" > @@ -148,6 +149,7 @@ tracing-journald =3D "0.3.1" > tracing-log =3D { version =3D "0.2", default-features =3D false } > tracing-subscriber =3D "0.3.16" > udev =3D "0.9" > +ureq =3D { version =3D "3", default-features =3D false } > url =3D "2.2" > walkdir =3D "2" > zstd =3D "0.13" > diff --git a/proxmox-http/Cargo.toml b/proxmox-http/Cargo.toml > index 66b11650..c1240fdf 100644 > --- a/proxmox-http/Cargo.toml > +++ b/proxmox-http/Cargo.toml > @@ -27,7 +27,7 @@ sync_wrapper =3D { workspace =3D true, optional =3D tru= e } > tokio =3D { workspace =3D true, features =3D [], optional =3D true } > tokio-openssl =3D { workspace =3D true, optional =3D true } > tower-service =3D { workspace =3D true, optional =3D true } > -ureq =3D { version =3D "3.0", features =3D ["native-tls"], optional =3D = true, default-features =3D false } > +ureq =3D { version =3D "3.0", features =3D ["native-tls"], optional =3D = true, default-features =3D false, workspace =3D true } You should drop the 'version' key when using it as a workspace dependency -- the main point of using a workspace dep is using the same version in the entire workspace, after all :) > url =3D { workspace =3D true, optional =3D true } > =20 > proxmox-async =3D { workspace =3D true, optional =3D true } > diff --git a/proxmox-openid/Cargo.toml b/proxmox-openid/Cargo.toml > index 5b031800..aed788d7 100644 > --- a/proxmox-openid/Cargo.toml > +++ b/proxmox-openid/Cargo.toml > @@ -22,7 +22,7 @@ thiserror.workspace =3D true > native-tls.workspace =3D true > =20 > openidconnect =3D { version =3D "4", default-features =3D false, feature= s =3D ["accept-rfc3339-timestamps"] } > -ureq =3D { version =3D "3", default-features =3D false, features =3D ["n= ative-tls", "gzip"] } > +ureq =3D { version =3D "3", default-features =3D false, features =3D ["n= ative-tls", "gzip"], workspace =3D true } same here > =20 > proxmox-time.workspace =3D true > proxmox-sys =3D { workspace =3D true, features =3D ["timer"] }