From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CA05C1FF142 for ; Tue, 21 Apr 2026 10:07:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7F1317930; Tue, 21 Apr 2026 10:07:19 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Apr 2026 10:07:16 +0200 Message-Id: Subject: Re: [PATCH proxmox-backup v3 22/23] daily-update: Refresh OAuth2 state for SMTP notification endpoints From: "Lukas Wagner" To: "Arthur Bied-Charreton" , X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260415070220.100306-1-a.bied-charreton@proxmox.com> <20260415070220.100306-23-a.bied-charreton@proxmox.com> In-Reply-To: <20260415070220.100306-23-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776758751625 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-daily-update.rs] Message-ID-Hash: 7AWKIYM6BMHYPMAUNOMYTSCSPCIJFXHG X-Message-ID-Hash: 7AWKIYM6BMHYPMAUNOMYTSCSPCIJFXHG X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi! One quick note inline. On Wed Apr 15, 2026 at 9:02 AM CEST, Arthur Bied-Charreton wrote: > Refresh tokens may expire if unused for extended periods of time. Force > refresh them in daily update to prevent this for idle endpoints. > > Signed-off-by: Arthur Bied-Charreton > --- > src/bin/proxmox-daily-update.rs | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/src/bin/proxmox-daily-update.rs b/src/bin/proxmox-daily-upda= te.rs > index c4d68e30..363f2901 100644 > --- a/src/bin/proxmox-daily-update.rs > +++ b/src/bin/proxmox-daily-update.rs > @@ -61,6 +61,15 @@ async fn do_update(rpcenv: &mut dyn RpcEnvironment) ->= Result<(), Error> { > log::error!("error checking certificates: {err}"); > } > =20 > + match pbs_config::notifications::config() { > + Ok(conf) =3D> { > + if let Err(e) =3D proxmox_notify::api::common::trigger_state= _refresh(&conf) { > + log::error!("Error refreshing notifications endpoints st= ate: {e}"); > + } > + } > + Err(e) =3D> log::error!("Error refreshing notifications endpoint= s state: {e}"), > + } > + The call into proxmox_notify is sync and potentially blocking, so this should be inside a `tokio::task::spawn_blocking` > // TODO: cleanup tasks like in PVE? > =20 > Ok(())