From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C5F321FF13C for ; Thu, 16 Apr 2026 13:21:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8A6632D6F; Thu, 16 Apr 2026 13:21:51 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 16 Apr 2026 13:21:47 +0200 Message-Id: From: "Dominik Rusovac" To: "Dominik Rusovac" , Subject: Re: [PATCH manager v2] ui: ha: add disarm/re-arm button X-Mailer: aerc 0.20.0 References: <20260415064118.33290-1-d.rusovac@proxmox.com> In-Reply-To: <20260415064118.33290-1-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776338429072 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.465 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: P5IO4LNRWJZY7HXTPT6L25PRT3LHFDNX X-Message-ID-Hash: P5IO4LNRWJZY7HXTPT6L25PRT3LHFDNX X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/pve-devel/20260416112033.148589-1-d= .rusovac@proxmox.com/T/#u On Wed Apr 15, 2026 at 8:41 AM CEST, Dominik Rusovac wrote: > The button to disarm HA in either of the resource modes ('freeze' or > 'ignore') is disabled as long as HA is disarmed. Analogously, the button > to arm HA is disabled as long as HA is not disarmed. > > The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA" > and "Arm HA" are complements. There may be more suitable pairs of icons > though. > > Signed-off-by: Dominik Rusovac > --- > changes since v1: > * use camel case for function names > * choose clearer parameter: 'comp' -> 'menuItem' > * choose clearer function names: > - 'disarm' -> 'handleDisarmButton' > - 'rearm' -> 'handleArmButton' > * deduplicate translation keys > * use same translation keys as for menu items > * remove obsolete 'params' > * change button text "Re-arm HA" to "Arm HA"=20 > * remove extra new-line > > www/manager6/ha/Status.js | 104 ++++++++++++++++++++++++++++++++++ > www/manager6/ha/StatusView.js | 8 +++ > 2 files changed, 112 insertions(+) > [snip]