Re: [PATCH datacenter-manager/proxmox-yew-comp v3 00/11] metric collection for the PDM host

["Michael Köppl" <m.koeppl@proxmox.com>]

Tested this series by:
- Purposefully making metrics unavailable (by setting psi=0 upon boot)
  to see that the UI still displays the remaining graphs correctly.
  It's printing errors to the journal on every iteration, but the graphs
  are displayed correctly (pressure stall graphs simply showing no
  values).
- Adding an additional interface, running some traffic through it and
  checking that traffic from the new interface is also included in the
  graph. Also checked that removing the interface does not cause
  problems.
- Created a separate interface, attached a bridge to it, created some
  traffic and checked that the graph only showed traffic from the
  physical interface.
- Generated some artificial load (stress-ng) and checked that the values
  displayed are as expected, especially with regards to memory/swap
  usage and memory pressure stall.
- Wrote a file with
    dd if=/dev/zero of=/root/testfile bs=1M count=1024 oflag=direct
  and checked that it was accurately reflected in the disk usage, disk
  transfer rate, IOPS, and IO pressure stall graphs.
- Played around a bit with the various RRD timeframes

Did not notice anything off. The metrics seem to display correctly and I
couldn't get the graphs to display anything weird.

I also had a look at the code, but also did not notice any problems in
this version of the series.

Nice work!

Consider this:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On Mon Apr 13, 2026 at 10:58 AM CEST, Lukas Wagner wrote:
> This series add metric collection physical PDM hosts.
>
> The patches for proxmox-yew-comp slight adapt the existing NodeStatusPanel to allow the application
> to inject child components into the same panel.
>
> The proxmox-datacenter-manager patches do some initial refactoring (naming), and then add the needed
> collection loop, API types and UI elements.
>
> Changes since v2:
>   - rebased
>   - adapted PDM part to changes in proxmox-disks (minor, only renaming)
>   - drop already applied patches for 'proxmox'
>   - drop patches for 'proxmox-backup' - these need to be adapted for the refactoring of
>     proxmox-disks and are pretty much independent of this series here, so they will be posted
>     separately
>
> Changes since v1:
>   - rebased
>   - fixed failing unit test
>   - fixed mistake in Cargo.toml
>   - dropped patch for proxmox-sys, Fabian fixed the issue
>     using another approach
>
>
> proxmox-yew-comp:
>
> Lukas Wagner (3):
>   node status panel: add `children` property
>   RRDGrid: fix size observer by attaching node reference to rendered
>     container
>   RRDGrid: add padding and increase gap between elements
>
>  src/node_status_panel.rs | 16 ++++++++++++++++
>  src/rrd_grid.rs          |  5 +++--
>  2 files changed, 19 insertions(+), 2 deletions(-)
>
>
> proxmox-datacenter-manager:
>
> Lukas Wagner (8):
>   metric collection: clarify naming for remote metric collection
>   metric collection: fix minor typo in error message
>   metric collection: collect PDM host metrics in a new collection task
>   api: fix /nodes/localhost/rrddata endpoint
>   pdm: node rrd data: rename 'total-time' to
>     'metric-collection-total-time'
>   pdm-api-types: add PDM host metric fields
>   ui: node status: add RRD graphs for PDM host metrics
>   ui: lxc/qemu/node: use RRD value render helpers
>
>  Cargo.toml                                    |   2 +
>  cli/client/src/metric_collection.rs           |   4 +-
>  debian/control                                |   2 +
>  lib/pdm-api-types/src/metric_collection.rs    |   2 +-
>  lib/pdm-api-types/src/rrddata.rs              |  74 ++++-
>  lib/pdm-client/src/lib.rs                     |   8 +-
>  server/Cargo.toml                             |   2 +
>  server/src/api/metric_collection.rs           |  10 +-
>  server/src/api/nodes/mod.rs                   |   2 +-
>  server/src/api/nodes/rrddata.rs               |  73 +++-
>  server/src/api/remotes.rs                     |   2 +-
>  server/src/api/rrd_common.rs                  |   2 +-
>  .../local_collection_task.rs                  | 199 +++++++++++
>  server/src/metric_collection/mod.rs           |  40 ++-
>  ...tion_task.rs => remote_collection_task.rs} |   8 +-
>  server/src/metric_collection/rrd_task.rs      | 187 ++++++++++-
>  server/src/metric_collection/state.rs         |   2 +-
>  ui/src/administration/node_status.rs          | 312 +++++++++++++++++-
>  ui/src/pbs/node/overview.rs                   |  29 +-
>  ui/src/pve/lxc/overview.rs                    |  34 +-
>  ui/src/pve/node/overview.rs                   |  29 +-
>  ui/src/pve/qemu/overview.rs                   |  34 +-
>  ui/src/renderer.rs                            |  49 +++
>  23 files changed, 955 insertions(+), 151 deletions(-)
>  create mode 100644 server/src/metric_collection/local_collection_task.rs
>  rename server/src/metric_collection/{collection_task.rs => remote_collection_task.rs} (99%)
>
>
> Summary over all repositories:
>   25 files changed, 974 insertions(+), 153 deletions(-)