From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 059FA1FF137 for ; Tue, 14 Apr 2026 15:48:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F8151A4AB; Tue, 14 Apr 2026 15:49:41 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 14 Apr 2026 15:49:07 +0200 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH manager] ui: ha: add disarm/re-arm button From: "Dominik Rusovac" X-Mailer: aerc 0.20.0 References: <20260414115156.188522-1-d.rusovac@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776174471390 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.487 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UKZ4JKMEV7QUZQ5DT7ZOVZJ2U7BA4XTK X-Message-ID-Hash: UKZ4JKMEV7QUZQ5DT7ZOVZJ2U7BA4XTK X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Apr 14, 2026 at 3:30 PM CEST, Daniel Kral wrote: > Nice work, looks great! > > I added some inline comments, but functionality-wise this works as > expected already. > thx! will incorporate your suggestions in a v2. > On Tue Apr 14, 2026 at 1:51 PM CEST, Dominik Rusovac wrote: >> The button to disarm HA in either of the resource modes ('freeze' or >> 'ignore') is disabled as long as HA is disarmed. Analogously, the >> re-arming button is disabled as long as HA is not disarmed. >> >> The icons ('unlink' and 'link') are chosen to emphasize that >> "Disarm HA" and "Re-arm HA" are complements. There may be more >> suitable pairs of icons though. >> >> Signed-off-by: Dominik Rusovac >> --- >> www/manager6/ha/Status.js | 106 ++++++++++++++++++++++++++++++++++ >> www/manager6/ha/StatusView.js | 8 +++ >> 2 files changed, 114 insertions(+) >> [snip]