Re: [PATCH docs 07/18] ha-manager: crs: remove note about manual changes to datacenter config

Shannon Sterz
2026-04-10T11:36:28Z

On Fri Apr 10, 2026 at 1:18 PM CEST, Daniel Kral wrote:
> On Fri Apr 10, 2026 at 10:17 AM CEST, Shannon Sterz wrote:
>> On Thu Apr 9, 2026 at 1:41 PM CEST, Daniel Kral wrote:

-->8 snip 8<--

>>> -(`Datacenter` -> `Options`), or directly in `datacenter.cfg`:
>>> -
>>> -----
>>> -crs: ha=static
>>> -----
>>> +(`Datacenter` -> `Options`).
>>>
>>> [thumbnail="screenshot/gui-datacenter-options-crs.png"]
>>>
>>
>> maybe not super "nice" but we could add the `pvesh` invocation here
>> instead? we seem to do that in other places that lack a dedicated cli
>> (e.g., [1]). so something like:
>>
>> pvesh set /cluster/options --crs "ha=static"
>>
>> [1]: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_add_mapping_for_shared_directories
>
> Thanks for the idea!
>
> Though I'm not entirely sure... I looked for instances where we show how
> to set datacenter config options in the documentation: We also do this
> for the style configuration [0] and for setting the default console [1].
>
> For the latter [1] I think it's alright as it's a single enum value, but
> for the style configuration [0] it might be destructive as it can
> replace the already existing tag-style options as it's a property
> string.
>
> Suggesting people the pvesh command would hide that the 'crs' option is
> a property string and might override other existing options. It would be
> a bit more user-friendly if there's an user interface like `git config`,
> where options can be set individually without interfering with other
> options.
>
> Hope this isn't to pedantic. What do you think?
>
> [0] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_style_configuration
> [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_shell_interface_for_the_proxmox_ve_api

i think that's a fair concern. however, admins that use the cli are
likely a bit more proficient anyway. so i think adding the command could
be helpful for users that really want to use the cli.

imo, we might just want to add a warning about how this is a property
string, the consequences of that, and to be careful when using the cli.
but no hard feelings, users familiar with `pvesh` and pve will be able
to figure out this invocation for themselves anyway.

if there are concrete plans for a cli that would improve this (i am not
aware of such efforts), that might be a sensible compromise.