Re: [PATCH proxmox-backup v4 2/3] fix #7400: api: gracefully handle corrupted job statefiles

["Shannon Sterz" <s.sterz@proxmox.com>]

-->8 snip 8<--


>>> @@ -191,11 +197,23 @@ impl JobState {
>>>      /// This does not update the state in the file.
>>>      pub fn load(jobtype: &str, jobname: &str) -> Result<Self, Error> {
>>>          if let Some(state) = file_read_optional_string(get_path(jobtype, jobname))? {
>>> -            match serde_json::from_str(&state)? {
>>> +            let job_state = match serde_json::from_str(&state) {
>>> +                Ok(parsed_state) => parsed_state,
>>> +                Err(err) => {
>>> +                    log::error!("could not parse statefile for {jobname}: {err}");
>>> +                    return Ok(JobState::Unknown);
>>> +                }
>>
>> kind of a stylistic choice, but i think the following might be slightly
>> neater here:
>>
>> ```
>> let Ok(job_sate) = serde_json::from_str(&state) else {
>>     log::error!("could not parse statefile for {jobname}: {err}");
>>     return Ok(JobState::Unknown);
>> }
>> ```
>
> AFAIK there's no way to get the error with let-else? It's why I chose
> the regular approach with match.
>

ah yeah sorry, missed that. and yeah true, you can't do that without
assigning the return value of the `from_str` call in between.

-->8 snip 8<--