From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0F6381FF140 for ; Fri, 10 Apr 2026 13:36:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ACB4F1BC4A; Fri, 10 Apr 2026 13:37:12 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 10 Apr 2026 13:37:07 +0200 Message-Id: Subject: Re: [PATCH docs 07/18] ha-manager: crs: remove note about manual changes to datacenter config To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260409114224.323102-1-d.kral@proxmox.com> <20260409114224.323102-8-d.kral@proxmox.com> In-Reply-To: From: "Shannon Sterz" X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775820957796 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DQXDQIG6CACQC3X5TK3MMQ2CNKR46T45 X-Message-ID-Hash: DQXDQIG6CACQC3X5TK3MMQ2CNKR46T45 X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri Apr 10, 2026 at 1:18 PM CEST, Daniel Kral wrote: > On Fri Apr 10, 2026 at 10:17 AM CEST, Shannon Sterz wrote: >> On Thu Apr 9, 2026 at 1:41 PM CEST, Daniel Kral wrote: -->8 snip 8<-- >>> -(`Datacenter` -> `Options`), or directly in `datacenter.cfg`: >>> - >>> ----- >>> -crs: ha=3Dstatic >>> ----- >>> +(`Datacenter` -> `Options`). >>> >>> [thumbnail=3D"screenshot/gui-datacenter-options-crs.png"] >>> >> >> maybe not super "nice" but we could add the `pvesh` invocation here >> instead? we seem to do that in other places that lack a dedicated cli >> (e.g., [1]). so something like: >> >> pvesh set /cluster/options --crs "ha=3Dstatic" >> >> [1]: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_add_mapping_= for_shared_directories > > Thanks for the idea! > > Though I'm not entirely sure... I looked for instances where we show how > to set datacenter config options in the documentation: We also do this > for the style configuration [0] and for setting the default console [1]. > > For the latter [1] I think it's alright as it's a single enum value, but > for the style configuration [0] it might be destructive as it can > replace the already existing tag-style options as it's a property > string. > > Suggesting people the pvesh command would hide that the 'crs' option is > a property string and might override other existing options. It would be > a bit more user-friendly if there's an user interface like `git config`, > where options can be set individually without interfering with other > options. > > Hope this isn't to pedantic. What do you think? > > [0] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_style_configur= ation > [1] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_shell_interfac= e_for_the_proxmox_ve_api i think that's a fair concern. however, admins that use the cli are likely a bit more proficient anyway. so i think adding the command could be helpful for users that really want to use the cli. imo, we might just want to add a warning about how this is a property string, the consequences of that, and to be careful when using the cli. but no hard feelings, users familiar with `pvesh` and pve will be able to figure out this invocation for themselves anyway. if there are concrete plans for a cli that would improve this (i am not aware of such efforts), that might be a sensible compromise.