From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 30CF91FF13F for ; Thu, 09 Apr 2026 11:52:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E3FA21DAE2; Thu, 9 Apr 2026 11:52:55 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Apr 2026 11:52:03 +0200 Message-Id: Subject: Re: [PATCH proxmox-perl-rs v2 08/16] pve-rs: notify: Add binding for triggering state refresh From: "Lukas Wagner" To: "Arthur Bied-Charreton" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260325131444.366808-1-a.bied-charreton@proxmox.com> <20260325131444.366808-9-a.bied-charreton@proxmox.com> In-Reply-To: <20260325131444.366808-9-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775728255428 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QVEAIWRUWX7HKNZPX5CMYK76DPC54XAZ X-Message-ID-Hash: QVEAIWRUWX7HKNZPX5CMYK76DPC54XAZ X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 25, 2026 at 2:14 PM CET, Arthur Bied-Charreton wrote: > Expose the new `trigger_state_refresh` proxmox-notify API to allow > update jobs to manually trigger a refresh of the crate's internal state. > > This currently only serves the purpose of preventing unused OAuth2 refres= h > tokens from expiring. > > Signed-off-by: Arthur Bied-Charreton > --- > common/src/bindings/notify.rs | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/common/src/bindings/notify.rs b/common/src/bindings/notify.r= s > index ff1e6cf..1f43d67 100644 > --- a/common/src/bindings/notify.rs > +++ b/common/src/bindings/notify.rs > @@ -141,6 +141,19 @@ pub mod proxmox_rs_notify { > api::common::send(&config, ¬ification) > } > =20 > + /// Method: Refresh the state for all endpoints. > + /// > + /// This iterates through all configured targets, refreshing their s= tate if needed. > + /// > + /// See [`api::common::refresh_targets`] > + #[export(serialize_error)] > + pub fn trigger_state_refresh( > + #[try_from_ref] this: &NotificationConfig, > + ) -> Result<(), HttpError> { > + let config =3D this.config.lock().unwrap(); > + api::common::trigger_state_refresh(&config) > + } > + > /// Method: Get a list of all notification targets. > /// > /// See [`api::get_targets`]. LGTM! Reviewed-by: Lukas Wagner