From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9E73D1FF13F for ; Thu, 09 Apr 2026 11:51:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F1CB1D745; Thu, 9 Apr 2026 11:52:23 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Apr 2026 11:51:54 +0200 Message-Id: Subject: Re: [PATCH proxmox v2 06/16] notify: smtp: Add XOAUTH2 authentication support From: "Lukas Wagner" To: "Arthur Bied-Charreton" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260325131444.366808-1-a.bied-charreton@proxmox.com> <20260325131444.366808-7-a.bied-charreton@proxmox.com> In-Reply-To: <20260325131444.366808-7-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775728246305 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NXMSDTLYXROHXPZDZ2ZP54AI73CHCNPC X-Message-ID-Hash: NXMSDTLYXROHXPZDZ2ZP54AI73CHCNPC X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 25, 2026 at 2:14 PM CET, Arthur Bied-Charreton wrote: > Extend the transport building logic to authenticate via XOAUTH2 if > configured, and manage the related state updates. > > Previously, the authentication method was determined based on the > presence of a password in the config. In order to ensure backwards > compatibility with older configurations, add an `auth_method` method > ensuring configurations that used PLAIN auth before this series > continue to do so without having to set it explicitly. > > Signed-off-by: Arthur Bied-Charreton > --- > proxmox-notify/src/endpoints/smtp.rs | 96 ++++++++++++++++++++++++---- > 1 file changed, 83 insertions(+), 13 deletions(-) > LGTM! Reviewed-by: Lukas Wagner