From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1597F1FF13F for ; Thu, 09 Apr 2026 11:51:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 827371D52A; Thu, 9 Apr 2026 11:51:55 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Apr 2026 11:51:51 +0200 Message-Id: Subject: Re: [PATCH proxmox v2 05/16] notify: smtp: Add state handling logic From: "Lukas Wagner" To: "Arthur Bied-Charreton" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260325131444.366808-1-a.bied-charreton@proxmox.com> <20260325131444.366808-6-a.bied-charreton@proxmox.com> In-Reply-To: <20260325131444.366808-6-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775728242747 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DX2LECVWZTTGNXRYHTJPN723SFJQYIBE X-Message-ID-Hash: DX2LECVWZTTGNXRYHTJPN723SFJQYIBE X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 25, 2026 at 2:14 PM CET, Arthur Bied-Charreton wrote: > Create new state file in add_endpoint, and create/update existing one in > update_endpoint. > > Add trigger_state_refresh to the Endpoint trait, with no-op default > implementation. Override trigger_state_refresh in SmtpEndpoint's > Endpoint impl to trigger an OAuth2 token exchange, in order to rotate > an existing token, or extend its lifetime. > > Since trigger_state_refresh is called in pveupdate, it may be called > multiple times in quick succession by the different nodes in the > cluster. In order to avoid unnecessary churn on the state files, the > last_refreshed field is used to check if the state has been refreshed > shortly before, and skip the update if it is the case. > [...] > diff --git a/proxmox-notify/src/api/smtp.rs b/proxmox-notify/src/api/smtp= .rs > index 4231cdae..1b25e5d3 100644 > --- a/proxmox-notify/src/api/smtp.rs > +++ b/proxmox-notify/src/api/smtp.rs > @@ -1,8 +1,9 @@ > use proxmox_http_error::HttpError; > =20 > use crate::api::{http_bail, http_err}; > +use crate::context::context; > use crate::endpoints::smtp::{ > - DeleteableSmtpProperty, SmtpConfig, SmtpConfigUpdater, SmtpPrivateCo= nfig, > + self, DeleteableSmtpProperty, SmtpConfig, SmtpConfigUpdater, SmtpPri= vateConfig, > SmtpPrivateConfigUpdater, SMTP_TYPENAME, > }; > use crate::Config; > @@ -69,6 +70,20 @@ pub fn add_endpoint( > &endpoint_config.name, > )?; > =20 > + if oauth2_refresh_token.is_some() { > + let oauth_state =3D smtp::State::from(oauth2_refresh_token); If you changes to a State::new as proposed two patches prior, this could just be a=20 if let Some(token) =3D oauth2_refresh_token { let oauth_state =3D smtp::state::new(token, proxmox_time::epoch_i64()); } > + > + context() > + .save_oauth_state(&endpoint_config.name, Some(oauth_state)) > + .map_err(|e| { > + http_err!( > + INTERNAL_SERVER_ERROR, > + "could not create state file for '{}': {e}", > + &endpoint_config.name > + ) > + })?; > + } > + with this fixed: Reviewed-by: Lukas Wagner