From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 83D701FF13F for ; Thu, 09 Apr 2026 11:51:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 787831D88D; Thu, 9 Apr 2026 11:52:24 +0200 (CEST) Content-Type: text/plain; charset=UTF-8 Date: Thu, 09 Apr 2026 11:51:48 +0200 Message-Id: Subject: Re: [PATCH proxmox v2 04/16] notify: smtp: Update API with OAuth2 parameters From: "Lukas Wagner" To: "Arthur Bied-Charreton" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty References: <20260325131444.366808-1-a.bied-charreton@proxmox.com> <20260325131444.366808-5-a.bied-charreton@proxmox.com> In-Reply-To: <20260325131444.366808-5-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775728239846 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WPRGPUQKNF3OOB7KBG2NR6G7L2D2MG26 X-Message-ID-Hash: WPRGPUQKNF3OOB7KBG2NR6G7L2D2MG26 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed Mar 25, 2026 at 2:14 PM CET, Arthur Bied-Charreton wrote: > Add the OAuth2 client & tenant ID to the public config, client secret to > the private config. > > The refresh token, which is to be managed separately as state, is taken > as an extra parameter by {add,update}_endpoint to avoid it landing in a > section config. > > Signed-off-by: Arthur Bied-Charreton Looks good to me. Reviewed-by: Lukas Wagner