From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ABB761FF13E for ; Fri, 03 Apr 2026 13:24:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 757A92E86; Fri, 3 Apr 2026 13:24:32 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 03 Apr 2026 13:23:58 +0200 Message-Id: From: =?utf-8?q?Michael_K=C3=B6ppl?= To: "Christian Ebner" , =?utf-8?q?Michael_K=C3=B6ppl?= , Subject: Re: [PATCH proxmox-backup v3 1/3] api: move statefile loading into compute_schedule_status X-Mailer: aerc 0.21.0 References: <20260325160617.342295-1-m.koeppl@proxmox.com> <20260325160617.342295-2-m.koeppl@proxmox.com> In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775215378976 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: L2HH7CO3NKTAFGJEUWBTXDMSVGU3TJQC X-Message-ID-Hash: L2HH7CO3NKTAFGJEUWBTXDMSVGU3TJQC X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu Apr 2, 2026 at 6:22 PM CEST, Christian Ebner wrote: [snip] >> let mut last =3D proxmox_time::epoch_i64(); >> =20 >> + let jobtype =3D "garbage_collection"; >> + >> if let Some(ref upid) =3D status_in_memory.upid { >> - let mut computed_schedule: JobScheduleStatus =3D JobScheduleSta= tus::default(); >> - if let Some(state) =3D state_file { >> - if let Ok(cs) =3D compute_schedule_status(&state, Some(upid= )) { >> - computed_schedule =3D cs; >> - } >> - } >> + let computed_schedule: JobScheduleStatus =3D >> + compute_schedule_status(jobtype, &store, Some(upid))?; > > comment: While the change in behavior here when parsing the UPID fails=20 > is fine as discussed in the previous patch series [0], this must be=20 > mentioned in the commit message! > > A short comment such as: > ``` > This also changes the error handling for UPID parsing errors with=20 > garbage collection state files, aligning it to the rest of the API=20 > handler behavior. > ``` Missed that, will adapt the commit message in a v4! Thanks > > Other than that, consider > > Reviewed-by: Christian Ebner > > [0]=20 > https://lore.proxmox.com/pbs-devel/DH6UARBSGJYA.172KMABDLD4GQ@proxmox.com= /