From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B23911FF13C for ; Thu, 02 Apr 2026 15:39:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4BA611B41A; Thu, 2 Apr 2026 15:40:26 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 02 Apr 2026 15:40:23 +0200 Message-Id: Subject: Re: [PATCH ha-manager v4 04/28] env: pve2: implement dynamic node and service stats From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260402124817.416232-1-d.kral@proxmox.com> <20260402124817.416232-5-d.kral@proxmox.com> In-Reply-To: <20260402124817.416232-5-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775137164593 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.497 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CZNJPM2YU2HFBHYKIDIN74L2DZLUYXZQ X-Message-ID-Hash: CZNJPM2YU2HFBHYKIDIN74L2DZLUYXZQ X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Thu Apr 2, 2026 at 2:43 PM CEST, Daniel Kral wrote: > Fetch the dynamic node and service stats with rrd_dump(), which is > periodically sampled and broadcasted by the PVE nodes' pvestatd service > and propagated through the pmxcfs. > > Signed-off-by: Daniel Kral > --- > changes v3 -> v4: > - introduce $HOSTNAME_RE and use it for nodename matching in > get_dynamic_node_stats() > [snip] Reviewed-by: Dominik Rusovac