From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 149D91FF13C
	for <inbox@lore.proxmox.com>; Thu, 02 Apr 2026 12:54:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 8A3A213336;
	Thu,  2 Apr 2026 12:55:23 +0200 (CEST)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 02 Apr 2026 12:55:19 +0200
Message-Id: <DHIM48VGB76J.2RTV4TFFCSPRQ@proxmox.com>
Subject: Re: [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>, <pdm-devel@lists.proxmox.com>
X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty
References: <20260309143827.3017628-1-d.csapak@proxmox.com>
In-Reply-To: <20260309143827.3017628-1-d.csapak@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1775127261488
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.054 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: MYGJAN6SBSCB3HN6KBVSJOY2SXFGMH2K
X-Message-ID-Hash: MYGJAN6SBSCB3HN6KBVSJOY2SXFGMH2K
X-MailFrom: l.wagner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pdm-devel-owner@lists.proxmox.com>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Subscribe: <mailto:pdm-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pdm-devel-leave@lists.proxmox.com>

On Mon Mar 9, 2026 at 3:37 PM CET, Dominik Csapak wrote:
> Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply
> use the 'node' one, since there can only be one for PBS anyway.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/pbs/node/mod.rs | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
> index abb1f6a6..6d2f46b8 100644
> --- a/ui/src/pbs/node/mod.rs
> +++ b/ui/src/pbs/node/mod.rs
> @@ -17,7 +17,7 @@ pub(crate) mod overview;
> =20
>  use overview::PbsNodeOverviewPanel;
> =20
> -use crate::get_deep_url_low_level;
> +use crate::{get_deep_url_low_level, remotes::RemoteTaskList};
> =20
>  #[derive(Clone, Debug, Eq, PartialEq, Properties)]
>  pub struct PbsNodePanel {
> @@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp {
>                      move |_| PbsNodeOverviewPanel::new(remote.clone()).i=
nto()
>                  },
>              )
> +            .with_item_builder(
> +                TabBarItem::new()
> +                    .key("tasks_view")
> +                    .label(tr!("Tasks"))
> +                    .icon_class("fa fa-list"),
> +                {
> +                    let remote =3D props.remote.clone();
> +                    move |_| RemoteTaskList::new().remote(remote.clone()=
).into()
> +                },
> +            )
>              .with_item_builder(
>                  TabBarItem::new()
>                      .key("update_view")

I wonder, should we also add a 'per-node' Tasks tab for PVE remotes?
What do you think?