From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AA8A31FF137 for ; Tue, 31 Mar 2026 10:15:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AA5312AC1; Tue, 31 Mar 2026 10:15:51 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 31 Mar 2026 10:15:17 +0200 Message-Id: Subject: Re: [PATCH ha-manager v3 31/40] usage: add dynamic usage scheduler From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260330144101.668747-1-d.kral@proxmox.com> <20260330144101.668747-32-d.kral@proxmox.com> In-Reply-To: <20260330144101.668747-32-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774944862408 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.486 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2BEHK3PL23DFNNS35TL7PCGEDNHBYGRK X-Message-ID-Hash: 2BEHK3PL23DFNNS35TL7PCGEDNHBYGRK X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm, consider this On Mon Mar 30, 2026 at 4:30 PM CEST, Daniel Kral wrote: > The dynamic usage scheduler allows the HA Manager to make scheduling > decisions based on the current usage of the nodes and cluster resources > in addition to the maximum usage stats as reported by the PVE::HA::Env > implementation. > > Signed-off-by: Daniel Kral > --- > changes v2 -> v3: > - add !defined(...) guards in PVE::HA::Usage::Dynamic::add_node(...) as > suggested by @Dominik > - adapt comment in add_service() as suggested by @Dominik > - did not change error messages as suggested by @Dominik, because these > are consistent with the one for Static; should be done in a separate > patch (series) > [snip] Reviewed-by: Dominik Rusovac