From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7E9691FF141 for ; Mon, 30 Mar 2026 08:01:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 858291707E; Mon, 30 Mar 2026 08:02:15 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 30 Mar 2026 08:01:37 +0200 Message-Id: Subject: Re: [PATCH cluster v2 19/40] datacenter config: add auto rebalancing options From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260324183029.1274972-1-d.kral@proxmox.com> <20260324183029.1274972-20-d.kral@proxmox.com> In-Reply-To: <20260324183029.1274972-20-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774850443865 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.207 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AP6NNTVF25XCE5HAI2ZQ4I5JSNFCXPXU X-Message-ID-Hash: AP6NNTVF25XCE5HAI2ZQ4I5JSNFCXPXU X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: see comment inline, otherwise lgtm On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote: > Signed-off-by: Daniel Kral > --- > changes v1 -> v2: > - slightly changed wording here (as suggested by @Maximiliano) [snip] > + 'ha-auto-rebalance-hold-duration' =3D> { > + type =3D> 'number', > + optional =3D> 1, > + default =3D> 3, > + requires =3D> 'ha-auto-rebalance', as mentioned in https://lore.proxmox.com/all/CALgSy_edrGdEqxts77qXgr-W331kMmrq1oH5dZMedfZvS= DCnbw@mail.gmail.com/, clarifying the unit of value 3 would be benficial=20 > + description =3D> "The duration the threshold must be exceeded fo= r to trigger an automatic" > + . " resource balancing migration in HA rounds.", > + }, [snip] Reviewed-by: Dominik Rusovac