From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 454E51FF141 for ; Mon, 30 Mar 2026 07:50:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CAD2E16E19; Mon, 30 Mar 2026 07:51:23 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 30 Mar 2026 07:50:49 +0200 Message-Id: Subject: Re: [PATCH cluster v2 17/40] datacenter config: restructure verbose description for the ha crs option From: "Dominik Rusovac" To: "Daniel Kral" , X-Mailer: aerc 0.20.0 References: <20260324183029.1274972-1-d.kral@proxmox.com> <20260324183029.1274972-18-d.kral@proxmox.com> In-Reply-To: <20260324183029.1274972-18-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774849795811 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.220 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7JWEMRLV7RTJBMQVP3ZINWIN55HAFQVJ X-Message-ID-Hash: 7JWEMRLV7RTJBMQVP3ZINWIN55HAFQVJ X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: see comment inline, otherwise lgtm On Tue Mar 24, 2026 at 7:30 PM CET, Daniel Kral wrote: > This makes it a little easier to read and allows appending descriptions > for other values with a cleaner diff. > > Signed-off-by: Daniel Kral > --- > changes v1 -> v2: > - new! > > src/PVE/DataCenterConfig.pm | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm > index d88b167..e7bc8f1 100644 > --- a/src/PVE/DataCenterConfig.pm > +++ b/src/PVE/DataCenterConfig.pm > @@ -17,9 +17,12 @@ my $crs_format =3D { > optional =3D> 1, > default =3D> 'basic', > description =3D> "Use this resource scheduler mode for HA.", > - verbose_description =3D> "Configures how the HA manager should s= elect nodes to start or " > - . "recover services. With 'basic', only the number of servic= es is used, with 'static', " > - . "static CPU and memory configuration of services is consid= ered.", > + verbose_description =3D> < +Configures how the HA Manager should select nodes to start or recover se= rvices: > + > +- with 'basic', only the number of services is used, > +- with 'static', static CPU and memory configuration of services is cons= idered. - with 'static', static CPU and memory configuration of services are co= nsidered. [snip] Reviewed-by: Dominik Rusovac