From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 87CF31FF140 for ; Fri, 27 Mar 2026 10:14:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C73D73704A; Fri, 27 Mar 2026 10:14:23 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Mar 2026 10:13:48 +0100 Message-Id: Subject: Re: [pve-devel] [PATCH installer] unconfigured: also catch ^C signal with debug shell From: "Christoph Heiss" To: "Proxmox VE development discussion" X-Mailer: aerc 0.21.0 References: <20251219185408.283433-1-c.heiss@proxmox.com> In-Reply-To: <20251219185408.283433-1-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774602779218 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FDIJMBZ43O4E7227YSXUVSTBH47ISM5Y X-Message-ID-Hash: FDIJMBZ43O4E7227YSXUVSTBH47ISM5Y X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Ping, still applies. On Fri Dec 19, 2025 at 7:54 PM CET, Christoph Heiss wrote: > Currently, pressing Ctrl-C during the installation - mostly relevant > when running the auto-installer - will cause a kernel panic, as > unconfigured.sh is running as PID 1. > > Instead, drop the user into our debug shell, which is a bit better UX > and more useful, too. > > Signed-off-by: Christoph Heiss > --- > unconfigured.sh | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/unconfigured.sh b/unconfigured.sh > index caa08c3..40e17b0 100755 > --- a/unconfigured.sh > +++ b/unconfigured.sh > @@ -3,6 +3,7 @@ > reboot_action=3D"reboot" > > trap "err_reboot" ERR > +trap "err_reboot" INT > > # NOTE: we nowadays get exec'd by the initrd's PID 1, so we're the new P= ID 1 > > @@ -75,6 +76,9 @@ eject_and_reboot() { > real_reboot() { > trap - ERR > > + # ignore ^C from this point, we are already shutting down > + trap '' INT > + > if [[ -x /etc/init.d/networking ]]; then > /etc/init.d/networking stop > fi