From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8A19C1FF140 for ; Fri, 27 Mar 2026 10:13:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EE9B36F0B; Fri, 27 Mar 2026 10:13:35 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Fri, 27 Mar 2026 10:13:31 +0100 Message-Id: Subject: Re: [pve-devel] [PATCH installer] post-hook: save post hook data to /run/proxmox-installer From: "Christoph Heiss" To: "Proxmox VE development discussion" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.21.0 References: <20251219140654.918419-1-c.heiss@proxmox.com> In-Reply-To: <20251219140654.918419-1-c.heiss@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774602761569 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C7OJYVJM55XYEAXGOPHOCOUTDPGK7IGR X-Message-ID-Hash: C7OJYVJM55XYEAXGOPHOCOUTDPGK7IGR X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Ping, still applies. On Fri Dec 19, 2025 at 3:06 PM CET, Christoph Heiss wrote: > Having the sent post-hook data available somewhere in the installatino > environment after the fact is seful for easily inspecting a > failed/rejected post-hook. > > Signed-off-by: Christoph Heiss > --- > It's a rather niche thing and more useful to developers than users. > Added this while working on the PDM integration, and thought it might be > nice to have this in general, especially since it does not have any > other impact. > > proxmox-post-hook/src/main.rs | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/proxmox-post-hook/src/main.rs b/proxmox-post-hook/src/main.r= s > index 9989389..a1aee1c 100644 > --- a/proxmox-post-hook/src/main.rs > +++ b/proxmox-post-hook/src/main.rs > @@ -662,6 +662,15 @@ fn do_main() -> Result<()> { > > let info =3D with_chroot(|target_path| PostHookInfo::gather(targ= et_path, &answer))?; > > + if let Err(err) =3D fs::write( > + "/run/proxmox-installer/post-hook-data.json", > + serde_json::to_string_pretty(&info)?, > + ) { > + eprintln!( > + "Failed to write post-installation-webhook data to /run/= proxmox-installer: {err:#}" > + ); > + } > + > proxmox_installer_common::http::post( > url, > cert_fingerprint.as_deref(),