From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 604451FF13F for ; Thu, 26 Mar 2026 11:28:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67922C7CD; Thu, 26 Mar 2026 11:29:17 +0100 (CET) Content-Type: text/plain; charset=UTF-8 Date: Thu, 26 Mar 2026 11:29:14 +0100 Message-Id: Subject: Re: [PATCH proxmox v2 06/40] resource-scheduling: topsis: handle empty criteria without panics From: "Dominik Rusovac" To: "Daniel Kral" , Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: aerc 0.20.0 References: <20260324183029.1274972-1-d.kral@proxmox.com> <20260324183029.1274972-7-d.kral@proxmox.com> In-Reply-To: <20260324183029.1274972-7-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774520905813 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.332 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BNSGV7A4YKZHISUM35Z7MVNLBNPOTV5C X-Message-ID-Hash: BNSGV7A4YKZHISUM35Z7MVNLBNPOTV5C X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm=20 On Tue Mar 24, 2026 at 7:29 PM CET, Daniel Kral wrote: [snip] > diff --git a/proxmox-resource-scheduling/src/topsis.rs b/proxmox-resource= -scheduling/src/topsis.rs > index 6d078aa6..ed5a9bd1 100644 > --- a/proxmox-resource-scheduling/src/topsis.rs > +++ b/proxmox-resource-scheduling/src/topsis.rs > @@ -145,8 +145,10 @@ impl IdealAlternatives { > let min =3D fixed_criterion > .clone() > .min_by(|a, b| a.total_cmp(b)) > - .unwrap(); > - let max =3D fixed_criterion.max_by(|a, b| a.total_cmp(b)).un= wrap(); > + .unwrap_or(f64::NEG_INFINITY); > + let max =3D fixed_criterion > + .max_by(|a, b| a.total_cmp(b)) > + .unwrap_or(f64::INFINITY); that's a very nice idea! [snip]