From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 81D801FF13F for ; Thu, 26 Mar 2026 11:10:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EF79B844; Thu, 26 Mar 2026 11:10:40 +0100 (CET) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 26 Mar 2026 11:10:34 +0100 Message-Id: To: "Daniel Kral" , Subject: Re: [PATCH proxmox v2 01/40] resource-scheduling: inline add_cpu_usage in score_nodes_to_start_service From: "Dominik Rusovac" X-Mailer: aerc 0.20.0 References: <20260324183029.1274972-1-d.kral@proxmox.com> <20260324183029.1274972-2-d.kral@proxmox.com> In-Reply-To: <20260324183029.1274972-2-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774519786163 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.333 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7WV4W3CBK24PFGMEQMKQJFOYKQJU6EBH X-Message-ID-Hash: 7WV4W3CBK24PFGMEQMKQJFOYKQJU6EBH X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm=20 On Tue Mar 24, 2026 at 7:29 PM CET, Daniel Kral wrote: > This makes moving the function out into its own module easier to follow, > which in turn is needed to generalize score_nodes_to_start_service(...) > for other usage stats in the following patches. > > Signed-off-by: Daniel Kral > --- > changes v1 -> v2: > - new! > > proxmox-resource-scheduling/src/pve_static.rs | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/proxmox-resource-scheduling/src/pve_static.rs b/proxmox-reso= urce-scheduling/src/pve_static.rs > index b81086dd..fd5e5ffc 100644 > --- a/proxmox-resource-scheduling/src/pve_static.rs > +++ b/proxmox-resource-scheduling/src/pve_static.rs > @@ -94,7 +94,11 @@ pub fn score_nodes_to_start_service>( > for (index, node) in nodes.iter().enumerate() { > let node =3D node.as_ref(); > let new_cpu =3D if index =3D=3D target_index { > - add_cpu_usage(node.cpu, node.maxcpu as f64, service.= maxcpu) > + if service.maxcpu =3D=3D 0.0 { > + node.cpu + node.maxcpu as f64 > + } else { > + node.cpu + service.maxcpu > + } > } else { > node.cpu > } / (node.maxcpu as f64);