From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id F3F701FF13F
	for <inbox@lore.proxmox.com>; Thu, 26 Mar 2026 09:20:26 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 8202B80C7;
	Thu, 26 Mar 2026 09:20:48 +0100 (CET)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 26 Mar 2026 09:20:12 +0100
Message-Id: <DHCKFNV3DPSD.1QNE710QGQGZM@proxmox.com>
Subject: Re: applied: [PATCH datacenter-manager 1/2] add `make tidy` target
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
 <pdm-devel@lists.proxmox.com>, "Lukas Wagner" <l.wagner@proxmox.com>
X-Mailer: aerc 0.21.0-0-g5549850facc2-dirty
References: <20260325134432.292489-1-l.wagner@proxmox.com>
 <177445770876.3365226.15945212122448861914.b4-ty@proxmox.com>
In-Reply-To: <177445770876.3365226.15945212122448861914.b4-ty@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1774513164302
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.047 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: LNL76YEI3XFUSJ366MAJ3I2264N32H24
X-Message-ID-Hash: LNL76YEI3XFUSJ366MAJ3I2264N32H24
X-MailFrom: l.wagner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pdm-devel-owner@lists.proxmox.com>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Subscribe: <mailto:pdm-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pdm-devel-leave@lists.proxmox.com>

On Wed Mar 25, 2026 at 5:55 PM CET, Thomas Lamprecht wrote:
> Side-note: would using --all for fmt make any difference here? Only check=
ed the
> output of `cargo fmt -h` which mentions "Format all packages, and also th=
eir
> local path-based dependencies", which might be relevant here for the work=
space
> local lib dependencies?
>

I tried this out before sending the patch. It seems like the `--all`
flag does not make a difference for us, in my experiments a regular
`cargo fmt` would also format all workspace members just fine, so
I left it at that.